Skip to content

Access list clients ordered insert #5421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edklesel wants to merge 2 commits into
base: develop
Choose a base branch
from
+18 −29
Open

Access list clients ordered insert #5421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84fb272
Merge pull request #5318 from NginxProxyManager/develop
jc21 Feb 17, 2026
1635e51
Change access list client insert to synchronous to ensure order prese…
Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 18 additions & 29 deletions backend/internal/access-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,20 +48,17 @@ const internalAccessList = {
return true;
});

// Clients
data.clients?.map((client) => {
promises.push(
accessListClientModel.query().insert({
access_list_id: row.id,
address: client.address,
directive: client.directive,
}),
);
return true;
});

await Promise.all(promises);

// Clients
for (const client of data.clients ?? []) {
await accessListClientModel.query().insert({
access_list_id: row.id,
address: client.address,
directive: client.directive,
});
}

// re-fetch with expansions
const freshRow = await internalAccessList.get(
access,
Expand Down Expand Up @@ -154,25 +151,17 @@ const internalAccessList = {

// Check for clients and add/update/remove them
if (typeof data.clients !== "undefined" && data.clients) {
const clientPromises = [];
data.clients.map((client) => {
if (client.address) {
clientPromises.push(
accessListClientModel.query().insert({
access_list_id: data.id,
address: client.address,
directive: client.directive,
}),
);
}
return true;
});

const query = accessListClientModel.query().delete().where("access_list_id", data.id);
await query;
// Add new clitens
if (clientPromises.length) {
await Promise.all(clientPromises);

for (const client of data.clients) {
if (client.address) {
await accessListClientModel.query().insert({
access_list_id: data.id,
address: client.address,
directive: client.directive,
});
}
}
}

Expand Down