fix(helm): git clone/sync containers need resources + sidecar probes#19
Merged
Conversation
The git-sync sidecar declared neither resource limits nor probes, so it is rejected by common admission policies that require both on every container (e.g. Kyverno require-resources / require-probes), which blocked the whole install. Add a configurable workspace.git.resources (sensible defaults) to both git containers, and lightweight exec liveness/readiness probes to the long-running sync sidecar (healthy once the workspace is cloned). The clone init container takes resources but no probes (short-lived). Bump chart to 0.1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On clusters that enforce resource limits and probes on every container (e.g. Kyverno
require-resources/require-probes, or a strictLimitRange), installing the chart withworkspace.git.sync.enabled=trueis rejected:The
git-syncsidecar (and thegit-cloneinit container) inherited onlysecurityContext, neverresourcesor probes.Fix
workspace.git.resources(default 10m/32Mi → 100m/64Mi) applied to both git containers.test -d $DEST/.git— healthy once cloned). The short-lived clone init container takes resources but no probes.0.1.0 → 0.1.1.Validation
helm lint✅ · rendered with sync enabled:git-cloneinit: resources ✅, no probes (correct)server/ui: unchanged (resources + 3 probes)git-sync: resources+limits ✅, liveness+readiness ✅Context
Surfaced deploying to a Kyverno-enforced K3s cluster (Neverdecel/starnode-core), where this blocked the install and git-sync had to be disabled. With this merged, auto-freshness can be re-enabled there.