fix upstream drop FontAwesome 4 font support#172
Draft
wirano wants to merge 1 commit intoNeutree:masterfrom
Draft
fix upstream drop FontAwesome 4 font support#172wirano wants to merge 1 commit intoNeutree:masterfrom
wirano wants to merge 1 commit intoNeutree:masterfrom
Conversation
Author
Owner
|
如果qtawesome直接移除了4的支持就比较糟糕了,像 fa.close 这种图标会直接报错吗 |
Author
|
@Neutree 缺少的图标都会报错类似下面这样 Click to expand |
Owner
|
这样的,那还是升级吧。 |
Author
|
那就在发版的时候提醒用户操作下?配置里硬编码的是 protocol 插件发送按钮的图标,应该是只要打开过插件就会受影响 |
Owner
|
感觉还是先限制requirements到 1.3.1 版本吧,反正图标更新影响也没那么大,但是不兼容之前的会有很多人遇到这个困扰 |
Author
|
那用滚动发行版的用户有难了(
在 2025年4月28日,21:48,Neucrack ***@***.***> 写道:
Neutree left a comment (Neutree/COMTool#172)
感觉还是先限制requirements到 1.3.1 版本吧,反正图标更新影响也没那么大,但是不兼容之前的会有很多人遇到这个困扰
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Owner
|
要是影响到其它项目了,用venv就好了 |
Author
|
通过发行版包管理/AUR 安装势必是跟着系统的依赖走的,还是得想一个优雅的解决方法 |
Owner
|
确实,最好就是兼容了,读取用户配置文件后检查图标,发现不合法,从内置一个表中自动替换为新版,如果表里面没有,弹出一个窗口让用户重新选择,用户也可以不选择则直接设置为一个默认图标 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qtawesome drop 了 fa4 支持,我这里替换成了高版本的 font awesome。
有一个问题是用户配置文件里也存了相关图标符号,不知道有没有除了删除配置外的平滑过渡方法