Merged
Conversation
Collaborator
|
The resulting error is one of the things I fixed in #167 by removing version locks: https://github.com/NeuroTechX/eeg-notebooks/pull/167/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552L48-R54 |
Collaborator
Author
|
ok thanks, I can add those back in here. the version specs seem to be important for some libs that break with new version of dependencies. but that's likely not the case for most of our dependencies, and indeed the converse is also an issue, as we have here. |
… will also need erik's tsplot fix) and psychopy
Collaborator
Author
|
woop woop we have a pass on docs build. I vote to merge. @ErikBjare you agree? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several issues with the current docs site. Need to solve this docs building issue, even if just a temporary fix, as we are (hoping for!) lots of eyes on this site right now.
AFAIK this has to be an iterative process of commit, check action status, commit, etc. Interactive prompt within gh actions would be handy, I don't know how to do that yet.