Fix for non-ascii characters in text annotations of open-ephys files#1827
Open
MarinManuel wants to merge 3 commits intoNeuralEnsemble:masterfrom
Open
Fix for non-ascii characters in text annotations of open-ephys files#1827MarinManuel wants to merge 3 commits intoNeuralEnsemble:masterfrom
MarinManuel wants to merge 3 commits intoNeuralEnsemble:masterfrom
Conversation
Contributor
|
Thanks @MarinManuel ! Would it make sense to always decode to be sure? (also to avoid the try-except?) What characters were causing issues? |
Author
|
My initial thought was also to always decode with utf8, but I did not want to risk breaking anything, so I choose the safer approach. I also assume the I had some text strings with the characters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open Ephys (binary, not sure about other format) files can contain text information that contains non-ascii characters. When trying to open such a file, the code fails with error:
This fix detects the
UnicodeDecodeErrorand falls back to decoding byte by byte use utf8 encoding.As far as I can tell, this change does not affect any of the existing tests. Let me know if we want to add a test with a file with non-ascii characters.