feat(integration-tests): add ATP Storage S3 integration#367
Open
elbe0116 wants to merge 1 commit intoNetcracker:feat/atp_robot_pluginfrom
Open
feat(integration-tests): add ATP Storage S3 integration#367elbe0116 wants to merge 1 commit intoNetcracker:feat/atp_robot_pluginfrom
elbe0116 wants to merge 1 commit intoNetcracker:feat/atp_robot_pluginfrom
Conversation
elbe0116
changed the title
elbe0116
force-pushed
the
feat/atp_robot_plugin
branch
from
2f0b607 to
eac9cde
Compare
anikin-aa
reviewed
Apr 1, 2026
| {{- end }} | ||
| {{- if .Values.tests.atpStorage.username }} | ||
| - name: ATP_STORAGE_USERNAME | ||
| value: {{ .Values.tests.atpStorage.username | quote }} |
Collaborator
There was a problem hiding this comment.
we can't store sentive information in CR, please use secrets
elbe0116
force-pushed
the
feat/atp_robot_plugin
branch
from
eac9cde to
141aa51
Compare
anikin-aa
reviewed
Apr 3, 2026
| - name: ATP_REPORT_ENABLED | ||
| value: {{ .Values.tests.atpReport.enabled | quote }} | ||
| - name: ATP_STORAGE_USERNAME | ||
| valueFrom: |
Collaborator
There was a problem hiding this comment.
Have you tested the changes? Or all of them were just generated by the AI Agent?
Collaborator
|
valueFrom is not going to work in CR. The CRD scheme should be regenerated (because of the new fields) Also, please move .Values.tests.atpStorage parameters group to a higher level, so it will be: .Values.atpStorage Such an approach with deploy parameters should be used in all services |
anikin-aa
requested changes
Apr 3, 2026
Collaborator
anikin-aa
left a comment
anikin-aa
left a comment
There was a problem hiding this comment.
Also, I don't see handling of new values in the Golang code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.