Skip to content

Expose CSI sidecar images in TridentOrchestrator#1156

Open
MaxRink wants to merge 1 commit into
NetApp:masterfrom
MaxRink:tcaas/expose-trident-sidecar-images
Open

Expose CSI sidecar images in TridentOrchestrator#1156
MaxRink wants to merge 1 commit into
NetApp:masterfrom
MaxRink:tcaas/expose-trident-sidecar-images

Conversation

@MaxRink

@MaxRink MaxRink commented Jun 22, 2026

Copy link
Copy Markdown

Summary

  • add explicit TridentOrchestrator fields for CSI sidecar image overrides
  • wire the fields into operator installation and currentInstallationParams
  • expose matching Helm values and render them into the TridentOrchestrator CR
  • update the custom-image example to include sidecar image overrides

Motivation

Trident already allows the operator environment to override CSI sidecar images, but TridentOrchestrator only exposes tridentImage, autosupportImage, and imageRegistry. Operators that manage image mirrors or version automation need a CR-level way to pin sidecar image names and tags without patching the operator Deployment environment.

CR-specified sidecar images take precedence over operator environment defaults and imageRegistry rewriting. Existing behavior remains unchanged when the new fields are omitted.

Validation

  • go test ./operator/controllers/orchestrator/installer ./operator/crd/apis/netapp/v1
  • helm lint ./helm/trident-operator
  • helm template ./helm/trident-operator with all new csiSidecar*Image values set
  • YAML parse for deploy/crds/tridentorchestrator_cr_customimage.yaml and helm/trident-operator/values.yaml
  • git diff --check

@torirevilla

Copy link
Copy Markdown
Contributor

If you wish to contribute to Trident please complete the necessary steps outlined in the CONTRIBUTING.md file, including the signed CCLA.

Sign and submit NetApp's Contributor License Agreement. You must sign and submit the Corporate Contributor License Agreement (CCLA) in order to contribute.

@MaxRink

MaxRink commented Jul 13, 2026

Copy link
Copy Markdown
Author

@torirevilla My Company has a valid signed CLA with NetApp

@github-actions

Copy link
Copy Markdown

Changelog label required

This PR must have exactly one changelog label before it can merge:

  • needs-changelog — user-facing change; add a release-note entry in the PR description (e.g. under a ## Changelog section)
  • no-changelog — no release note needed; please add a brief rationale in the PR description (e.g. under the changelog question in the PR template)

Set needs-changelog or no-changelog on this PR in the GitHub labels panel (right sidebar). That re-runs the required Changelog label validation check automatically.

Merge is blocked only until one of these labels is set — release note or rationale text in the PR description is encouraged but not required to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants