Skip to content

utils/mount/mount_linux.go: replace 'mkdir -p' invocation with MkdirAll() standard Go function#1152

Open
timp87 wants to merge 1 commit into
NetApp:masterfrom
timp87:mount_linux-no-mkdir-cmd
Open

utils/mount/mount_linux.go: replace 'mkdir -p' invocation with MkdirAll() standard Go function#1152
timp87 wants to merge 1 commit into
NetApp:masterfrom
timp87:mount_linux-no-mkdir-cmd

Conversation

@timp87

@timp87 timp87 commented Jun 3, 2026

Copy link
Copy Markdown

Change description

It makes trident possible to use on Talos at least with NFS #806

mount.nfs* tools are already being added to the image, see https://github.com/NetApp/trident/blob/v26.02.1/Dockerfile#L13 for example.

So mkdir was the only reason why trident could not be used on Talos with NFS4.

Does this code need a note in the changelog?

Customer won't see the difference, so rather no.

@torirevilla

Copy link
Copy Markdown
Contributor

If you wish to contribute to Trident please complete the necessary steps outlined in the CONTRIBUTING.md file, including the signed CCLA.

Sign and submit NetApp's Contributor License Agreement. You must sign and submit the Corporate Contributor License Agreement (CCLA) in order to contribute.

@timp87

timp87 commented Jun 16, 2026

Copy link
Copy Markdown
Author

@torirevilla done

@ohauer

ohauer commented Jul 2, 2026

Copy link
Copy Markdown

I'm running into the same issue (talos + trident) and wonder why a util written in go depends on external tools like mkdir instead using os.Mkdir / os.MkdirAll

@timp87

timp87 commented Jul 3, 2026

Copy link
Copy Markdown
Author

@praveene12 why did you commit this here?
Can you revert it please if it was done accidentally?

@praveene12

Copy link
Copy Markdown
Contributor

@timp87 I did not make this commit into your branch as I have checked. Could you check rebasing please

…ll() standard Go function

It makes trident possible to use on Talos at least with NFS NetApp#806

mount.nfs* tools are already being added to the image, see https://github.com/NetApp/trident/blob/v26.02.1/Dockerfile#L13 for example.

So `mkdir` was the only reason why trident could not be used on Talos with NFS4
@timp87 timp87 force-pushed the mount_linux-no-mkdir-cmd branch from c3bf926 to 6481508 Compare July 10, 2026 19:08
@timp87

timp87 commented Jul 10, 2026

Copy link
Copy Markdown
Author

Ok, I've resolved the conflict

@github-actions

Copy link
Copy Markdown

Changelog label required

This PR must have exactly one changelog label before it can merge:

  • needs-changelog — user-facing change; add a release-note entry in the PR description (e.g. under a ## Changelog section)
  • no-changelog — no release note needed; please add a brief rationale in the PR description (e.g. under the changelog question in the PR template)

Set needs-changelog or no-changelog on this PR in the GitHub labels panel (right sidebar). That re-runs the required Changelog label validation check automatically.

Merge is blocked only until one of these labels is set — release note or rationale text in the PR description is encouraged but not required to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants