utils/mount/mount_linux.go: replace 'mkdir -p' invocation with MkdirAll() standard Go function#1152
utils/mount/mount_linux.go: replace 'mkdir -p' invocation with MkdirAll() standard Go function#1152timp87 wants to merge 1 commit into
Conversation
b303040 to
515cff8
Compare
|
If you wish to contribute to Trident please complete the necessary steps outlined in the CONTRIBUTING.md file, including the signed CCLA. Sign and submit NetApp's Contributor License Agreement. You must sign and submit the Corporate Contributor License Agreement (CCLA) in order to contribute. |
|
@torirevilla done |
|
I'm running into the same issue (talos + trident) and wonder why a util written in go depends on external tools like mkdir instead using os.Mkdir / os.MkdirAll |
|
@praveene12 why did you commit this here? |
|
@timp87 I did not make this commit into your branch as I have checked. Could you check rebasing please |
…ll() standard Go function It makes trident possible to use on Talos at least with NFS NetApp#806 mount.nfs* tools are already being added to the image, see https://github.com/NetApp/trident/blob/v26.02.1/Dockerfile#L13 for example. So `mkdir` was the only reason why trident could not be used on Talos with NFS4
c3bf926 to
6481508
Compare
|
Ok, I've resolved the conflict |
Changelog label requiredThis PR must have exactly one changelog label before it can merge:
Set Merge is blocked only until one of these labels is set — release note or rationale text in the PR description is encouraged but not required to merge. |
Change description
It makes trident possible to use on Talos at least with NFS #806
mount.nfs* tools are already being added to the image, see https://github.com/NetApp/trident/blob/v26.02.1/Dockerfile#L13 for example.
So
mkdirwas the only reason why trident could not be used on Talos with NFS4.Does this code need a note in the changelog?
Customer won't see the difference, so rather no.