New pistol/smg/rifle/shotgun weapon classifications#1995
Open
sunzenshen wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
In reference to: #1805 (comment) |
AdamTadeusz
approved these changes
Jun 19, 2026
Masterkatze
reviewed
Jun 19, 2026
| // SUPPRESSED - Suppressed weapons | ||
| // EXPLOSIVE - Generic for weapons that count as explosive kills on killfeed. | ||
| // SHOTGUN - Weapons with shotgun spread | ||
| // BATTLERIFLE - Semi-auto rifles |
Contributor
There was a problem hiding this comment.
Maybe we should add ASSAULTRIFLE too while we're at it?
Contributor
Author
There was a problem hiding this comment.
I thought about it, but I wanted to keep changes limited to gameplay significant changes.
Otherwise then it brings up philosophical questions of what bits should we set the BALC, PBK, and PZ to. Is it easier to classify them as Assault Rifles? Is the PBK an SMG? etc.
Alternatively maybe it makes more sense to brand things along the lines of SCOPEDWEAPON? e.g. instead of BATTLERIFLE, specify something instead like AUTOWEAPON vs. SEMIWEAPON, but I'm not sure about the wording of the latter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New weapon flags for pistols/smgs/shotguns/rifles, to simplify bot weapon flag checks.
Toolchain