Allow DeckEntrances on Deck and deprecate deckEntranceCouples#952
Open
Robbendebiene wants to merge 4 commits intoNeTEx-CEN:nextfrom
Open
Allow DeckEntrances on Deck and deprecate deckEntranceCouples#952Robbendebiene wants to merge 4 commits intoNeTEx-CEN:nextfrom
DeckEntrances on Deck and deprecate deckEntranceCouples#952Robbendebiene wants to merge 4 commits intoNeTEx-CEN:nextfrom
Conversation
Allow DeckEntranceRef definitions under Deck to link between Decks of same vehicle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves: #702
In contrast to the above suggestion this deprecates
deckEntranceCouplesas proposed here: https://3.basecamp.com/4847067/buckets/19640795/messages/8724984447Initially I wanted to keep the idea of coupling for different carriages by adding refs to the
TrainComponentCouplingStructure(see code below). However this still doesn't allow the coupling of 2 carriage entrances with the sameDeckPlanso I did not do it. Coupling betweenDeckEntrancesmarked as communicating can still be done implicitly based on theirVehicleSideand the order + details of the respectiveTrainComponents.Discarded idea for explicit coupling of DeckEntrances from different DeckPlans