New better timetable example from Slovenia#765
Open
atibaut wants to merge 1 commit intoNeTEx-CEN:masterfrom
Open
New better timetable example from Slovenia#765atibaut wants to merge 1 commit intoNeTEx-CEN:masterfrom
atibaut wants to merge 1 commit intoNeTEx-CEN:masterfrom
Conversation
This example of a timetable replaces the file Netex_09.2_Bus_SimpleTimetable_Slovenia.xml. The timetable was created from a national NeTEx service in Slovenia (Ministry of Transport/NCUP).
Contributor
|
fine for me, but maybe put if in NeTEx\examples\standards\slovenia rather than in NeTEx\examples\functions\timetable ? |
Contributor
|
@atibaut my suggestion would be to change pos to posList. That would already save a considerable amount of data. I notice that ScheduledStopPointRef, ServiceLinkRef, OperatingDayRef, DayTypeRef all lack the version attribute, that this is not being picked up, is a bug in the XML Schema. |
This was referenced Sep 4, 2024
Contributor
|
This is not true the attribute is present but optional. because you may choose to have versionRef or version defepending on whether it is an internal or external ref. |
Contributor
|
@atibaut pls update the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example of a timetable replaces the file Netex_09.2_Bus_SimpleTimetable_Slovenia.xml. The timetable was created from a national NeTEx service in Slovenia (Ministry of Transport/NCUP).