fix X2jOptions type by defining two distinct types depending on jPath value#805
Open
KuSh wants to merge 1 commit intoNaturalIntelligence:masterfrom
Open
fix X2jOptions type by defining two distinct types depending on jPath value#805KuSh wants to merge 1 commit intoNaturalIntelligence:masterfrom
KuSh wants to merge 1 commit intoNaturalIntelligence:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
Avoid type check errors for current fxp users by not pushing the new path-expression-matcher Matcher type on them.
fixes #803
Unfortunately I didn't found an elegant solution to avoid duplicating types, something I've tested was like:
Unfortunately I'm not sure the end user experience will be good. I can update the PR into that if you prefer.
Type
Please mention the type of PR