Fix HTML entities showing in support form#374
Merged
Conversation
The product card descriptions on the support request form were showing literal "&" because passing interpolated attribute values to a Flux component re-escapes them. Replaced "&" with "and" to dodge the double-encoding entirely. Also replaced raw " " entities in the Steps to Reproduce placeholder with PHP_EOL via attribute binding so newlines render reliably, and swapped the "⌘" entity in the reply hint for the literal "⌘" character. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The customer support request form was rendering literal HTML entities in the UI:
&(e.g. "iOS & Android apps") because passing an interpolated value to a Flux component attribute (description="{{ $product['desc'] }}") ends up double-encoding —{{ }}runse()once, then the component template echoes it through{{ }}again. HTML entity references, which under some render paths come through as literal text rather than newlines.⌘for the Mac Command symbol with the same risk.Changes
resources/views/livewire/customer/support/create.blade.php&withandin the product card descriptions to dodge the Flux double-escape entirely.placeholder="… …"to a:placeholder="implode(PHP_EOL, [...])"binding so newlines render reliably.resources/views/livewire/customer/support/show.blade.php⌘with the literal⌘character in the reply hint.tests/Feature/SupportFormPlaceholderTest.php and renders real newlines.Test plan
php artisan test --compact tests/Feature/SupportTicketTest.php tests/Feature/SupportFormPlaceholderTest.php— all 83 tests pass🤖 Generated with Claude Code