fix(ios): convert gallery HEIC/HEIF to JPEG for WebView compatibility#7
Open
shreejanpandit wants to merge 1 commit into
Open
fix(ios): convert gallery HEIC/HEIF to JPEG for WebView compatibility#7shreejanpandit wants to merge 1 commit into
shreejanpandit wants to merge 1 commit into
Conversation
Gallery picker copied HEIC as-is while camera capture already saves JPEG. WKWebView cannot display HEIC in img elements. Convert only heic/heif extensions after copy; other formats unchanged.
shreejanpandit
force-pushed
the
fix/ios-gallery-heic-to-jpeg
branch
from
9bde901 to
d55c6ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On iOS, camera capture saves photos as JPEG, and the README states “JPEG for photos”.
The gallery picker copies files as-is via
loadFileRepresentation. On iPhone that is often HEIC/HEIF. Those files are valid on disk, but WKWebView cannot display HEIC in<img>, so profile/media previews in Livewire, Blade, or Inertia fail even when upload still works.Camera and gallery therefore behave differently within the same plugin.
Solution
In
copyFileToCache, after copying to cache:heicorheif, convert to JPEG withjpegData(compressionQuality: 0.9)(same as camera capture)..jpgpath andimage/jpegmime type.~35 lines in
resources/ios/CameraFunctions.swiftonly. No change toprocessPickerResultsor event payload shape.Why this is needed