Jf/set initial param levels#98
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 83.13% 82.22% -0.92%
==========================================
Files 45 45
Lines 2325 2509 +184
==========================================
+ Hits 1933 2063 +130
- Misses 392 446 +54 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 12 changed files in this pull request and generated 23 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 12 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| has_storages = haskey(f, "storages") | ||
| has_generatorstorages = haskey(f, "generatorstorages") | ||
|
|
||
| if has_storages |
There was a problem hiding this comment.
Let's pull these blocks into 2 functions read_storages() and read_genstorages(), which take the file handle and the version as a symbol and passes 0 for version <0.9, and passes read-in SoC to the asset struct which is sent back to the calling function. We can then call this in core and can do the same thing as before for 0_5 and 0_8. Same deal with read_demandresponses() except we only check for versions 0_8 and 0_9.
| load_matrix(f["storages/carryoverefficiency"], region_order, Float64), | ||
| load_matrix(f["storages/failureprobability"], region_order, Float64), | ||
| load_matrix(f["storages/repairprobability"], region_order, Float64); | ||
| initial_soc = load_matrix(f["storages/initialsoc"], region_order, Float64) |
There was a problem hiding this comment.
Why not read with read_vector?
Creating initial PR now-will update with graphics/analysis on impact in varying param. Core functionality with backwards compat file reading tests is present though