Correct variable name used in imx93, imx6ull, and imx8mm configs, properly create partition table if required#5
Open
Correct variable name used in imx93, imx6ull, and imx8mm configs, properly create partition table if required#5
Conversation
Additionally, I do not believe that root permissions are required to use parted since we are not accessing a block device.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The board definitions in this repo do not work with imx93, imx6ull, or imx8mm as the variable in those board configs was defined as IMAGE_PT_TABLE_STRUCT, while utils.sh expects IMAGE_PT_TBL_STRUCT.
Additionally, attempting to use parted on the file created with "truncate -s" does not work as parted fails immediately because it does not recognize the disk label. If the partition type is "MBR", parted is called to create a new msdos disk label before attempting to create any partitions.
I also do not believe that sudo is required to make these images, as the disk image being manipulated is owned by the user running the script.
This fixes some of the problems that I was having with #4, but I am still digging into this. I'm not entirely sure what to do with the host tools being older than the tools built in Yocto other than creating the swupdate image within Yocto and only using this repo as a reference.