Skip to content

Update AeroJEPA README with latest results#1855

Open
mnabian wants to merge 2 commits into
mainfrom
mnabian-patch-1
Open

Update AeroJEPA README with latest results#1855
mnabian wants to merge 2 commits into
mainfrom
mnabian-patch-1

Conversation

@mnabian

@mnabian mnabian commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

PhysicsNeMo Pull Request

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@mnabian mnabian self-assigned this Jul 17, 2026
@mnabian

mnabian commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test c4b8d83

@mnabian
mnabian requested a review from ktangsali July 17, 2026 23:48
@greptile-apps

greptile-apps Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the AeroJEPA benchmark table in the README with new paper-scale results that match or exceed the original paper numbers, removes the Mean TFLOPs column (previously TBD), and renames the recipe row from "tutorial-scale" to "paper-scale".

  • The benchmark table row label was changed from tutorial-scale to paper-scale and all numeric values were refreshed with improved results.
  • The Mean TFLOPs column was dropped from the table header and data rows.
  • Three prose passages surrounding the table (lines 172, 183, and 186\u2013189) were not updated: they still say "tutorial-scale" and the Note on line 186 references TFLOPs, which no longer appears in the table.

Important Files Changed

Filename Overview
examples/cfd/external_aerodynamics/aerojepa/README.md Updates benchmark table with paper-scale results and removes the TFLOPs column, but leaves three surrounding prose passages that still say "tutorial-scale" and one Note that references the now-removed TFLOPs column, creating internal contradictions in the documentation.

Comments Outside Diff (1)

  1. examples/cfd/external_aerodynamics/aerojepa/README.md, line 172-189 (link)

    P1 Stale "tutorial-scale" references after rename to "paper-scale"

    The table row was renamed from tutorial-scale to paper-scale, but three pieces of surrounding prose were not updated to match: line 172 ("the second is this recipe's tutorial-scale run"), line 183 ("The last block is this recipe's tutorial-scale run"), and the Note on lines 186–189, which explains that tutorial-scale defaults are smaller than the paper configuration and references TFLOPs — a column that was also removed from the table. All three passages now contradict the table label and the Note's TFLOPs mention refers to a column that no longer exists.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Reviews (1): Last reviewed commit: "Update README.md" | Re-trigger Greptile

@mnabian
mnabian enabled auto-merge July 18, 2026 00:07
@mnabian
mnabian requested a review from negin513 July 18, 2026 00:08
@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.23%. Comparing base (e571668) to head (fe9e7f4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1855      +/-   ##
==========================================
- Coverage   72.23%   72.23%   -0.01%     
==========================================
  Files         858      858              
  Lines       62629    62629              
  Branches     9337     9337              
==========================================
- Hits        45240    45239       -1     
- Misses      14226    14228       +2     
+ Partials     3163     3162       -1     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant