You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.
This PR updates the AeroJEPA benchmark table in the README with new paper-scale results that match or exceed the original paper numbers, removes the Mean TFLOPs column (previously TBD), and renames the recipe row from "tutorial-scale" to "paper-scale".
The benchmark table row label was changed from tutorial-scale to paper-scale and all numeric values were refreshed with improved results.
The Mean TFLOPs column was dropped from the table header and data rows.
Three prose passages surrounding the table (lines 172, 183, and 186\u2013189) were not updated: they still say "tutorial-scale" and the Note on line 186 references TFLOPs, which no longer appears in the table.
Updates benchmark table with paper-scale results and removes the TFLOPs column, but leaves three surrounding prose passages that still say "tutorial-scale" and one Note that references the now-removed TFLOPs column, creating internal contradictions in the documentation.
Comments Outside Diff (1)
examples/cfd/external_aerodynamics/aerojepa/README.md, line 172-189 (link)
Stale "tutorial-scale" references after rename to "paper-scale"
The table row was renamed from tutorial-scale to paper-scale, but three pieces of surrounding prose were not updated to match: line 172 ("the second is this recipe's tutorial-scale run"), line 183 ("The last block is this recipe's tutorial-scale run"), and the Note on lines 186–189, which explains that tutorial-scale defaults are smaller than the paper configuration and references TFLOPs — a column that was also removed from the table. All three passages now contradict the table label and the Note's TFLOPs mention refers to a column that no longer exists.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.23%. Comparing base (e571668) to head (fe9e7f4). ⚠️ Report is 1 commits behind head on main.
❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.