Add non-periodic grid gradient boundary mode#1853
Draft
loliverhennigh wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
boundary="one_sided"torectilinear_grid_gradientanduniform_grid_gradientboundary="periodic"as the default with the existing periodic code path unchangedWhy
Periodic wrapping mixes values from opposite edges on bounded, non-periodic domains and corrupts boundary derivatives. Callers currently need to mask or replace those values themselves.
The explicit boundary mode is backward-compatible and leaves room for additional boundary treatments in the future.
Validation
uv run --group dev python -m pytest -q test/nn/functional/derivativesuv run ruff check <changed Python files>uv run ruff format --check <changed Python files>boundary: str = "periodic"Tests cover analytic boundary derivatives, uniform/rectilinear equivalence, torch/Warp forward parity, torch/Warp backward parity, fourth-order stencil radius handling, invalid modes, and insufficient axis lengths.
Closes #1852.