Mesh: Add differentiable exact RBF mesh morphing#1830
Open
mehdiataei wants to merge 3 commits into
Open
Conversation
Signed-off-by: Mehdi Ataei <ataei8@gmail.com>
mehdiataei
requested review from
ktangsali,
loliverhennigh,
megnvidia and
peterdsharpe
as code owners
July 10, 2026 22:54
Contributor
Greptile SummaryThis PR adds exact RBF morphing for tensors and meshes. The main changes are:
Important Files Changed
Reviews (1): Last reviewed commit: "Add exact RBF mesh morphing" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
This PR adds dimensionally generic thin-plate-spline radial basis function (RBF) morphing for points and meshes.
The new APIs include:
rbf_morph_pointsfor batched or unbatched tensor inputs.Mesh.rbf_morphfor individual meshes.DomainMesh.rbf_morphfor applying one fitted field across all domain components.PyTorch performs the differentiable coefficient solve. Field evaluation supports both PyTorch and a fused NVIDIA Warp backend, with automatic device-based dispatch. The implementation supports an optional affine polynomial tail, smoothing, and per-point weights. With zero smoothing, the fitted field interpolates control displacements before optional point weights are applied.
The PyTorch implementation supports first- and second-order gradients. The Warp evaluator supports first-order gradients through query points, control locations, control displacements, and floating-point weights. Input validation reports invalid layouts and singular control systems with actionable errors.
Documentation includes reproducible 2D and 3D examples and visualizations.
Validation completed:
Checklist
Dependencies
No new dependencies.
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.