fix(datapipes): write domain-level global_data in SetGlobalField#1820
Open
peterdsharpe wants to merge 3 commits into
Open
fix(datapipes): write domain-level global_data in SetGlobalField#1820peterdsharpe wants to merge 3 commits into
peterdsharpe wants to merge 3 commits into
Conversation
SetGlobalField.apply_to_domain broadcast injected fields to every sub-mesh's global_data but never wrote them to the DomainMesh's own domain-level global_data, so code reading DomainMesh.global_data never saw the fields. The domain path now writes both records; sub-mesh behavior is unchanged.
peterdsharpe
force-pushed
the
psharpe/globaldata-domain-transforms
branch
from
July 10, 2026 05:10
99f90d6 to
6540a0a
Compare
- New test: injecting an existing key overwrites the domain-level record, matching the documented contract. - One-line docstrings on the test class, methods, and helper, matching neighboring test files.
peterdsharpe
marked this pull request as ready for review
July 14, 2026 02:44
Contributor
Greptile SummaryThis PR fixes
Important Files Changed
Reviews (1): Last reviewed commit: "Merge branch 'main' into psharpe/globald..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SetGlobalField.apply_to_domainbroadcast the injected fields to every sub-mesh'sglobal_data, but never wrote them to theDomainMesh's own domain-levelglobal_data. Any code readingDomainMesh.global_datanever saw the injected fields.Meshbehavior is unchanged.Tests
New
test/datapipes/transforms/test_set_global_field.py:global_datareceives the fieldMeshpath unchangedFull transforms suite passes; ruff check/format clean.
Notes
SetDomainGlobalField) that this fix makes unnecessary.ComputeUnitGlobalVector) that was previously bundled in this PR is now split out into draft PR feat(datapipes): add ComputeUnitGlobalVector transform #1825, since it is new API rather than a bug fix.