Fix grid-to-point interpolation edge cases#1813
Draft
loliverhennigh wants to merge 2 commits into
Draft
Conversation
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Hardens
grid_to_point_interpolationfor use inside differentiable geometry functionals.This fixes three independent edge cases in the existing operation:
float32neighbors and interior grid nodes on both Torch and Warp;The Warp implementation receives the original logical bounds and computes endpoint-adjacent cells and fractions without a size-scaled tolerance band. Tests cover 1D, 2D, and 3D endpoint gradients, exact-vs-
nextafterbehavior, interior-node rounding, dtype preservation, and non-leaf custom-op inputs.Validation
47 passedintest_grid_to_point_interpolation.py167 passed, 16 skippedacross geometry functionals and grid-to-point interpolationChecklist
Dependencies
None.