Update torchvision version to 0.25.0a0#1694
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Greptile SummaryThis PR updates the
Important Files Changed
Reviews (1): Last reviewed commit: "Update torchvision version to 0.25.0a0" | Re-trigger Greptile |
|
/blossom-ci |
|
cc. @abokov-nv for viz. |
|
The goal here is to allow the prerelease in our pyproject.toml? |
Normal users installing from pypi won't be affected by this. Pip will not select pre-release packages unless --pre is specified or the pre-release is already present. The Production Branch Pytorch container (which is based on 26.03 Feature Branch Pytorch container) has a pre-release torchvision (0.25.0a0). Without this change, this line will force an update of torch vision followed by torch. While this should technically be ok, it causes ABI breakage of some libraries like transformer-engine (we rely on transformer-engine shipped in the PyTorch container). Also, we don't want to be overwriting the core packages like torch/transformer-engine etc. from the base container, at least for some of the more latest pytorch container releases. Having this change now also future proofs next SFB release. For 25.08, we will likely use the same production branch (PB6, because PB7 won't be out for another 6-7 months) and will hit this issue again (hence the change to main. For 25.06 builds, I have already created a separate branch with this change and tested the build) |
|
/blossom-ci |
PhysicsNeMo Pull Request
Description
Update the lower bound of torchvision version to satisfy the NVAIE builds. Without this, the pip install will update torchvision (and with it, torch too) which breaks the builds.
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.