Fix model signature from from_torch (#1349)#1350
Merged
CharlelieLrt merged 6 commits intoNVIDIA:mainfrom Feb 13, 2026
Merged
Conversation
* Use original `__init__` signature instead of reconstructing it Signed-off-by: giprayogo <genki016@gmail.com>
Contributor
Greptile OverviewGreptile SummarySimplified
Important Files Changed
|
Collaborator
|
/blossom-ci |
Collaborator
|
/blossom-ci |
Collaborator
|
/blossom-ci |
Collaborator
|
/blossom-ci |
CharlelieLrt
approved these changes
Feb 13, 2026
Collaborator
CharlelieLrt
left a comment
There was a problem hiding this comment.
@loliverhennigh can comment on that, but looks good to me
nbren12
pushed a commit
to nbren12/modulus
that referenced
this pull request
Mar 24, 2026
* Use original `__init__` signature instead of reconstructing it Signed-off-by: giprayogo <genki016@gmail.com> Co-authored-by: Charlelie Laurent <84199758+CharlelieLrt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Fix
Module.from_torch()dropping keyword-only arguments from__init__signature.Description
Closes #1349 .
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.