Do not set --stopping-criterion entropy via CLI in autotune Python example - #457
Open
oleksandr-pavlyk wants to merge 1 commit into
Open
Conversation
Use `Benchmark.set_stopping_criterion("entropy")` in the script
instead.
This declares correct intent for benchmark to use entropy-criterion
by default.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Python autotuning example removes the entropy stopping criterion from subprocess arguments and configures it through the registered NVBench benchmark. ChangesBenchmark autotuning
Assessment against linked issues
Suggested reviewers: Comment |
oleksandr-pavlyk
enabled auto-merge (squash)
August 11, 2026 21:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Benchmark.set_stopping_criterion("entropy")in the script instead.This declares correct intent for benchmark to use entropy-criterion by default.
Closes #456