Skip to content

Do not set --stopping-criterion entropy via CLI in autotune Python example - #457

Open
oleksandr-pavlyk wants to merge 1 commit into
NVIDIA:mainfrom
oleksandr-pavlyk:python-example-benchmark-result-autotune-tweak
Open

Do not set --stopping-criterion entropy via CLI in autotune Python example#457
oleksandr-pavlyk wants to merge 1 commit into
NVIDIA:mainfrom
oleksandr-pavlyk:python-example-benchmark-result-autotune-tweak

Conversation

@oleksandr-pavlyk

Copy link
Copy Markdown
Collaborator

Use Benchmark.set_stopping_criterion("entropy") in the script instead.

This declares correct intent for benchmark to use entropy-criterion by default.

Closes #456

Use `Benchmark.set_stopping_criterion("entropy")` in the script
instead.

This declares correct intent for benchmark to use entropy-criterion
by default.
@oleksandr-pavlyk oleksandr-pavlyk self-assigned this Aug 11, 2026
@oleksandr-pavlyk oleksandr-pavlyk added the area: examples Related to example code. label Aug 11, 2026
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Aug 11, 2026
@oleksandr-pavlyk

This comment was marked as outdated.

@coderabbitai

This comment was marked as outdated.

@oleksandr-pavlyk oleksandr-pavlyk moved this from Todo to In Review in CCCL Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 741312d1-4f20-4b91-8446-49b20a0dada9

📥 Commits

Reviewing files that changed from the base of the PR and between c184889 and fb56d73.

📒 Files selected for processing (1)
  • python/examples/benchmark_result_autotune.py

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated benchmark configuration to apply the entropy stopping criterion consistently through the benchmarking API.
    • Removed the obsolete command-line option from subprocess benchmark launches.

Walkthrough

The Python autotuning example removes the entropy stopping criterion from subprocess arguments and configures it through the registered NVBench benchmark.

Changes

Benchmark autotuning

Layer / File(s) Summary
Configure the benchmark stopping criterion
python/examples/benchmark_result_autotune.py
The subprocess no longer receives --stopping-criterion entropy. The registered benchmark now calls set_stopping_criterion("entropy").

Assessment against linked issues

Objective Addressed Explanation
Remove the hard-coded --stopping-criterion option from the underlying benchmark invocation and configure entropy through the benchmark API [#456]

Suggested reviewers: naderalawar


Comment @coderabbitai help to get the list of available commands.

@oleksandr-pavlyk
oleksandr-pavlyk enabled auto-merge (squash) August 11, 2026 21:00
@oleksandr-pavlyk oleksandr-pavlyk changed the title Do not set --stopping-criterion entropy via CLI in example Do not set --stopping-criterion entropy via CLI in autotune Python example Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: examples Related to example code. python

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

Python example benchmark_result_autotune.py should not set --stopping-criterion option calling the underlying benchmark

1 participant