fix(nvue-client): Add polling in NvueClient::apply_config_revision - #4791
Conversation
…VIDIA#4729) I've been overly optimistic in `NvueClient::apply_config_revision()`, assuming that we don't need to care about checking the state of the revision we just applied. QA found a bug (tracked internally as NVbugs 6563638) that suggests this was a mistake. This branch adds polling logic in `apply_config_revision()`, with parsing of the revision data derived from the OpenAPI spec from NVUE in Cumulus Linux 5.16.0 (the most recent version I had handy). ## Related issues - NVbugs 6563638 ## Type of Change - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [X] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes - [ ] **This PR contains breaking changes** ## Testing - [X] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🔐 TruffleHog Secret Scan🚨 Potential secrets detected! TruffleHog found potential secrets in your code changes. This could include:
📋 View Detailed Findings👉 Click here to view the full TruffleHog scan results The job logs contain:
Next Steps
Security Best Practices
🕐 Last updated: 2026-08-10 21:06:17 UTC | Commit: 280fdda |
nv-dmendoza
left a comment
There was a problem hiding this comment.
LGTM, truffle scan issue is separate from this change
This is a backport to v2.1 of #4729 (which the following text is from).
I've been overly optimistic in
NvueClient::apply_config_revision(), assuming that we don't need to care about checking the state of the revision we just applied. QA found a bug (tracked internally as NVbugs 6563638) that suggests this was a mistake. This branch adds polling logic inapply_config_revision(), with parsing of the revision data derived from the OpenAPI spec from NVUE in Cumulus Linux 5.16.0 (the most recent version I had handy).Related issues
Type of Change
Breaking Changes
Testing
Additional Notes