Skip to content

fix(nvue-client): Add polling in NvueClient::apply_config_revision - #4791

Merged
nv-dmendoza merged 1 commit into
NVIDIA:release/v2.1from
DrewBloechl:drew/backport-4729-to-v2.1
Aug 10, 2026
Merged

fix(nvue-client): Add polling in NvueClient::apply_config_revision#4791
nv-dmendoza merged 1 commit into
NVIDIA:release/v2.1from
DrewBloechl:drew/backport-4729-to-v2.1

Conversation

@DrewBloechl

Copy link
Copy Markdown
Contributor

This is a backport to v2.1 of #4729 (which the following text is from).

I've been overly optimistic in NvueClient::apply_config_revision(), assuming that we don't need to care about checking the state of the revision we just applied. QA found a bug (tracked internally as NVbugs 6563638) that suggests this was a mistake. This branch adds polling logic in apply_config_revision(), with parsing of the revision data derived from the OpenAPI spec from NVUE in Cumulus Linux 5.16.0 (the most recent version I had handy).

Related issues

  • NVbugs 6563638

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

…VIDIA#4729)

I've been overly optimistic in `NvueClient::apply_config_revision()`,
assuming that we don't need to care about checking the state of the
revision we just applied. QA found a bug (tracked internally as NVbugs
6563638) that suggests this was a mistake. This branch adds polling
logic in `apply_config_revision()`, with parsing of the revision data
derived from the OpenAPI spec from NVUE in Cumulus Linux 5.16.0 (the
most recent version I had handy).

## Related issues
- NVbugs 6563638

## Type of Change
- [ ] **Add** - New feature or capability
- [ ] **Change** - Changes in existing functionality
- [X] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.)

## Breaking Changes
- [ ] **This PR contains breaking changes**

## Testing
- [X] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Manual testing performed
- [ ] No testing required (docs, internal refactor, etc.)

## Additional Notes
@DrewBloechl
DrewBloechl requested a review from a team August 10, 2026 21:03
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 93111e35-4fa0-472d-9b02-317d75b3db72

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

🚨 Potential secrets detected!

TruffleHog found potential secrets in your code changes. This could include:

  • 🔑 API keys and tokens
  • 🔐 Passwords and credentials
  • 🎫 OAuth tokens
  • 🗝️ Private keys

📋 View Detailed Findings

👉 Click here to view the full TruffleHog scan results

The job logs contain:

  • Exact file paths and line numbers
  • Secret types detected
  • Verification status (verified/unverified)

Next Steps

  1. Review Details: Check the scan logs for specific findings
  2. Verify Findings: Determine if detected items are actual secrets
  3. Remove Secrets: If real, remove them from your code immediately
  4. Rotate Credentials: Revoke and regenerate any leaked credentials
  5. Prevent Future Leaks: Add sensitive files to .gitignore

Security Best Practices

⚠️ Never commit secrets to your repository! Use:

  • Environment variables for configuration
  • Secret management tools (Vault, AWS Secrets Manager, etc.)
  • GitHub Secrets for CI/CD workflows
  • .env files (added to .gitignore)

📖 Learn more about TruffleHog

🕐 Last updated: 2026-08-10 21:06:17 UTC | Commit: 280fdda

@nv-dmendoza nv-dmendoza left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, truffle scan issue is separate from this change

@nv-dmendoza
nv-dmendoza merged commit adaf327 into NVIDIA:release/v2.1 Aug 10, 2026
120 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants