Skip to content

fix(cherry-pick): discovery cleanup bug + dell machine_setup_status fix - #4719

Open
krish-nvidia wants to merge 1 commit into
NVIDIA:release/v2.0from
krish-nvidia:cherry-pick-dell
Open

fix(cherry-pick): discovery cleanup bug + dell machine_setup_status fix#4719
krish-nvidia wants to merge 1 commit into
NVIDIA:release/v2.0from
krish-nvidia:cherry-pick-dell

Conversation

@krish-nvidia

Copy link
Copy Markdown
Contributor

This PR:

  • Skips Dell iDRAC unlock and relock states during initial-discovery cleanup, preventing lockdown before UEFI password setup.
  • Preserves existing lockdown behavior for deprovision cleanup.
  • Bumps libredfish to v0.44.21.1 to verify Dell HttpDev1TlsMode during machine setup, preventing hosts from getting stuck in WaitingForDiscovery when TLS remains enabled.

Related issues

#4704
#4710

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Signed-off-by: Krish Dandiwala <kdandiwala@nvidia.com>
@krish-nvidia krish-nvidia self-assigned this Aug 7, 2026
@krish-nvidia
krish-nvidia requested a review from a team August 7, 2026 20:32
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 583b47cb-a526-4bc6-a5d8-548c00720089

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

🚨 Potential secrets detected!

TruffleHog found potential secrets in your code changes. This could include:

  • 🔑 API keys and tokens
  • 🔐 Passwords and credentials
  • 🎫 OAuth tokens
  • 🗝️ Private keys

📋 View Detailed Findings

👉 Click here to view the full TruffleHog scan results

The job logs contain:

  • Exact file paths and line numbers
  • Secret types detected
  • Verification status (verified/unverified)

Next Steps

  1. Review Details: Check the scan logs for specific findings
  2. Verify Findings: Determine if detected items are actual secrets
  3. Remove Secrets: If real, remove them from your code immediately
  4. Rotate Credentials: Revoke and regenerate any leaked credentials
  5. Prevent Future Leaks: Add sensitive files to .gitignore

Security Best Practices

⚠️ Never commit secrets to your repository! Use:

  • Environment variables for configuration
  • Secret management tools (Vault, AWS Secrets Manager, etc.)
  • GitHub Secrets for CI/CD workflows
  • .env files (added to .gitignore)

📖 Learn more about TruffleHog

🕐 Last updated: 2026-08-07 20:37:38 UTC | Commit: ad8aa71

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

🔍 Container Scan Summary

Service Total Critical High Medium Low Other
boot-artifacts-aarch64 3 0 0 3 0 0
boot-artifacts-x86_64 3 0 0 3 0 0
forge-admin-cli-x86_64 268 16 33 81 7 131
machine-validation-runner 566 41 125 190 22 188
machine_validation 566 41 125 190 22 188
machine_validation-aarch64 566 41 125 190 22 188
nvmetal-carbide 566 41 125 190 22 188
TOTAL 2538 180 533 847 95 883

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant