fix: discovery cleanup bug + dell machine_setup_status fix

[krish-nvidia]

This PR:

• Skips Dell iDRAC unlock and relock states during initial-discovery cleanup, preventing lockdown before UEFI password setup.
• Preserves existing lockdown behavior for deprovision cleanup.
• Bumps libredfish to v0.46.4 to verify Dell HttpDev1TlsMode during machine setup, preventing hosts from getting stuck in WaitingForDiscovery when TLS remains enabled.

Related issues

#4704
#4710

Type of Change

• Add - New feature or capability
• Change - Changes in existing functionality
• Fix - Bug fixes
• Remove - Removed features or deprecated functionality
• Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

• This PR contains breaking changes

Testing

• Unit tests added/updated
• Integration tests added/updated
• Manual testing performed
• No testing required (docs, internal refactor, etc.)

Additional Notes

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 50a737a6-9137-4220-9a6c-817dae5bebed

📥 Commits

Reviewing files that changed from the base of the PR and between f4805c5 and 66e64e3.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

• Cargo.toml
• crates/bmc-explorer/src/hw/dell.rs
• crates/machine-controller/src/handler.rs

---

Summary by CodeRabbit

• Bug Fixes

  • Improved Dell BIOS discovery by recognizing the HttpDev1TlsMode setting.
  • Updated BOSS storage cleanup behavior to avoid unnecessary BMC lock and unlock operations during initial discovery.
  • Streamlined initial discovery after BOSS volume creation, reducing unnecessary workflow transitions.

• Compatibility

  • Updated underlying hardware-management support to improve compatibility with the latest supported Redfish capabilities.

Walkthrough

The PR updates the libredfish dependency, adds a Dell BIOS attribute expectation, and changes BOSS cleanup transitions so BMC locking occurs only during deprovisioning.

Changes

Dell Redfish compatibility

Layer / File(s)	Summary
Redfish dependency and BIOS contract Cargo.toml, crates/bmc-explorer/src/hw/dell.rs	The workspace now uses libredfish tag v0.46.4. Dell BIOS expectations now include HttpDev1TlsMode with value "None".

BOSS cleanup workflow

Layer / File(s)	Summary
Context-specific BOSS cleanup states crates/machine-controller/src/handler.rs	Deprovisioning performs BMC unlock and lock operations. Initial discovery skips those operations and transitions directly to post-cleanup after BOSS volume creation.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant MachineController
  participant BMC
  participant BOSS
  MachineController->>BOSS: initialize secure erase by cleanup context
  alt Deprovision
    MachineController->>BMC: unlock before BOSS cleanup
    BOSS-->>MachineController: volume creation complete
    MachineController->>BMC: lock after volume creation
  else Initial discovery
    BOSS-->>MachineController: volume creation complete
    MachineController->>MachineController: transition directly to post-cleanup
  end

Loading

Possibly related issues

• bug: initial discovery cleanup locks down Dell hosts before setting UEFI password #4710 — The PR implements the issue objectives by skipping BMC lockdown during initial discovery and avoiding the LockHost state after BOSS volume creation.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the discovery cleanup bug and Dell machine setup fix covered by the changes.
Description check	✅ Passed	The description accurately covers both fixes, the libredfish update, related issues, and manual testing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[martinraumann]

logic lgtm