Skip to content

fix: update digest lookup to use versioned RepoTags instead of latest #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivakunv wants to merge 1 commit into
base: main
Choose a base branch
from
+41 −25
Open

fix: update digest lookup to use versioned RepoTags instead of latest #1935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 39 additions & 23 deletions .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,31 +27,35 @@
"recreateWhen": "always",
"separateMultipleMajor": false,
"separateMinorPatch": false,
"pruneStaleBranches": true,
"rebaseWhen": "always",
"force": {
"createPr": true,
"createPrEvenIfClosed": true
Comment thread
rahulait marked this conversation as resolved.
},

"customManagers": [
{
"customType": "regex",
"managerFilePatterns": [
"bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml"
"deployments/gpu-operator/values.yaml"
],
"matchStrings": [
"[-\\s]*value:\\s*\"?(?<depName>[^:\"]+)(?::(?<currentValue>[^@\"]+))?@(?<currentDigest>sha256:[a-f0-9]{64})\"?",
"[-\\s]*image: (?<depName>.*?)(?::(?<currentValue>.*?))?@(?<currentDigest>sha256:[a-f0-9]{64})",
"- name: (?<suffix>[\\w-]+)[-\\s]*image: (?<depName>.*?)(?::(?<currentValue>.*?))?@(?<currentDigest>sha256:[a-f0-9]{64})"
"[-\\s]*repository:\\s*(?<repo>\\S+)\\s*\\n(?:\\s*#.*\\n|\\s*\\n)*[-\\s]*image:\\s*(?<image>\\S+)\\s*\\n(?:\\s*#.*\\n|\\s*\\n)*[-\\s]*version:\\s*(?<currentValue>\\S+)"
Comment thread
shivakunv marked this conversation as resolved.
],
"versioningTemplate": "{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}",
"datasourceTemplate": "docker"
"depNameTemplate": "{{repo}}/{{image}}",
Comment thread
shivakunv marked this conversation as resolved.
"datasourceTemplate": "docker",
"versioningTemplate": "loose"
},
{
"customType": "regex",
"managerFilePatterns": [
"deployments/gpu-operator/values.yaml"
"bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml"
],
"matchStrings": [
"[-\\s]*repository:\\s*(?<repo>\\S+)\\s*\\n(?:\\s*#.*\\n|\\s*\\n)*[-\\s]*image:\\s*(?<image>\\S+)\\s*\\n(?:\\s*#.*\\n|\\s*\\n)*[-\\s]*version:\\s*(?<currentValue>\\S+)"
"(?:value|image):\\s*[\"']?(?<depName>[^:\"'\\s]+):(?<currentValue>[^@\"'\\s]+)@(?<currentDigest>sha256:[a-f0-9]{64})"
],
"depNameTemplate": "{{repo}}/{{image}}",
"datasourceTemplate": "docker",
"versioningTemplate": "loose"
"datasourceTemplate": "docker"
}
],
"labels": [
Expand All @@ -60,44 +64,56 @@
],
"packageRules": [
{
"matchPaths": ["deployments/gpu-operator/values.yaml"],
"matchPackageNames": [
"nvcr.io/nvidia/cloud-native/k8s-driver-manager",
"nvcr.io/nvidia/cloud-native/k8s-kata-manager",
"nvcr.io/nvidia/cloud-native/vgpu-device-manager",
"nvcr.io/nvidia/cloud-native/k8s-cc-manager",
"nvcr.io/nvidia/cloud-native/nvidia-sandbox-device-plugin",
"nvcr.io/nvidia/kubevirt-gpu-device-plugin",
"nvcr.io/nvidia/k8s-device-plugin",
"nvcr.io/nvidia/k8s/container-toolkit",
"nvcr.io/nvidia/cloud-native/k8s-mig-manager"
"nvcr.io/nvidia/k8s-device-plugin"
],
"versioning": "regex:^v?(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)$",
"separateMajorMinor": false
},
{
"matchPaths": ["deployments/gpu-operator/values.yaml"],
"matchPackageNames": [
"nvcr.io/nvidia/k8s/dcgm-exporter"
"nvcr.io/nvidia/cloud-native/k8s-mig-manager"
],
"versioning": "regex:^v?(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)-distroless$",
"versioning": "regex:^v?(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)$",
"separateMajorMinor": false
},
{
"matchPaths": ["deployments/gpu-operator/values.yaml"],
"matchPackageNames": [
"nvcr.io/nvidia/cuda"
],
"matchPackageNames": ["nvcr.io/nvidia/cuda"],
"versioning": "regex:^(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)-base-ubi9$",
"separateMajorMinor": false
},
{
"matchPackageNames": ["nvcr.io/nvidia/k8s/dcgm-exporter"],
"versioning": "regex:^(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)-(?<build>\\d+)\\.(?<revision>\\d+)\\.(?<compatibility>\\d+)-distroless$",
"separateMajorMinor": false
},
{
"matchPackageNames": ["nvcr.io/nvidia/cloud-native/dcgm"],
"versioning": "regex:^(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)-(?<revision>\\d+)-ubi9$",
"separateMajorMinor": false
},
{
"matchPackageNames": ["nvcr.io/nvidia/k8s/container-toolkit"],
"versioning": "regex:^v?(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)(?:-rc\\.(?<prerelease>\\d+))?$",
"ignoreUnstable": false,
"separateMajorMinor": false
},
{
"matchPackageNames": ["nvcr.io/nvidia/driver"],
"enabled": false
},
{
"matchDatasources": ["*"],
"groupName": "{{depName}}"
"matchDatasources": ["docker"],
"groupName": "{{depName}}",
"branchTopic": "{{depName}}",
"commitMessageTopic": "{{depName}}"
}
]
}
4 changes: 2 additions & 2 deletions deployments/gpu-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ dcgm:
enabled: false
repository: nvcr.io/nvidia/cloud-native
image: dcgm
version: 4.5.2-1-ubuntu22.04
version: 4.5.2-1-ubi9
Copy link
Copy Markdown
Contributor

@cdesiniotis cdesiniotis Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change made?

Copy link
Copy Markdown
Contributor

@cdesiniotis cdesiniotis Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this so that the image in the CSV file and helm values are identical, and therefore, renovate can update them simaltaneously?

Copy link
Copy Markdown
Contributor

@rajathagasthya rajathagasthya Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

Copy link
Copy Markdown
Contributor Author

@shivakunv shivakunv Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.
refer : #1935 (comment)

imagePullPolicy: IfNotPresent
args: []
env: []
Expand Down Expand Up @@ -498,7 +498,7 @@ kataSandboxDevicePlugin:
enabled: true
repository: nvcr.io/nvidia/cloud-native
image: nvidia-sandbox-device-plugin
version: "v0.0.2"
version: v0.0.2
imagePullPolicy: IfNotPresent
imagePullSecrets: []
args: []
Expand Down
Loading