Skip to content

fix(update-version): don't blanket replace the word main with release branch in README.md - #2421

Open
gforsyth wants to merge 1 commit into
NVIDIA:mainfrom
gforsyth:hotfix/26.08_to_main
Open

fix(update-version): don't blanket replace the word main with release branch in README.md#2421
gforsyth wants to merge 1 commit into
NVIDIA:mainfrom
gforsyth:hotfix/26.08_to_main

Conversation

@gforsyth

@gforsyth gforsyth commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Hotfix for 26.08 release.

2 weeks ago this commit dd84ab5#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R159-R167 added some helpful new documentation to the README.md in cuvs.

It's a rust example and so it uses fn main() in the example code. update-version.sh looks everywhere for branch references that should be updated to release/26.08 and it did that, which then broke the rust doctests.

So, we fix update-version to be a little more measured in its replacements, then we have to cut a hotfix release on top of 26.08 for cuvs to get the rust artifacts published.

This PR is for making sure this commit also lands in main so this doesn't happen again.

xref #2420

@gforsyth
gforsyth requested a review from a team as a code owner August 6, 2026 13:25
@gforsyth gforsyth added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 6, 2026
@gforsyth
gforsyth requested a review from jameslamb August 6, 2026 13:25
@gforsyth gforsyth changed the title fix(update-version): don't blanket replace the word main with release branch in fix(update-version): don't blanket replace the word main with release branch in README.md Aug 6, 2026

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants