Fix CWD-relative CUTLASS C++ compilation cache (#3404) - #3442
Open
notkisk wants to merge 2 commits into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3404.
cutlass_cppgenpreviously stored compiled artifacts incompiled_cache.dbrelative to the process working directory. This allowed an attacker-controlled database to supply a native library that was loaded through
ctypes.CDLL.This change:
CUTLASS_CPPGEN_CACHE,XDG_CACHE_HOME, or~/.cache/cutlass_cppgen.Existing CWD-local caches are intentionally no longer used and will be rebuilt in the new per-user cache location.
Testing