tighten wheel size limits, expand CI-skipping logic, other small build changes #804
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -111,66 +111,145 @@ jobs: | |
| uses: rapidsai/shared-workflows/.github/workflows/changed-files.yaml@main | ||
| with: | ||
| files_yaml: | | ||
| build_docs: | ||
| - '**' | ||
| - '!.ai/**' | ||
| - '!.coderabbit.yaml' | ||
| - '!.github/AGENTS.md' | ||
| - '!.github/CODE_OF_CONDUCT.md' | ||
| - '!.github/CODEOWNERS' | ||
| - '!.github/ISSUE_TEMPLATE/**' | ||
| - '!.github/PULL_REQUEST_TEMPLATE.md' | ||
| - '!.github/SECURITY.md' | ||
| - '!.github/.ai/**' | ||
| - '!.github/.coderabbit_review_guide.md' | ||
| - '!.github/agents/**' | ||
| - '!.github/copy-pr-bot.yaml' | ||
| - '!.github/ops-bot.yaml' | ||
| - '!.pre-commit-config.yaml' | ||
| - '!ci/build_wheel*.sh' | ||
| - '!ci/check_style.sh' | ||
| - '!ci/release/**' | ||
| - '!ci/run_ctests.sh' | ||
| - '!ci/run_*.pytests.sh' | ||
| - '!ci/test_cpp*.sh' | ||
| - '!ci/test_notebooks.sh' | ||
| - '!ci/test_python.sh' | ||
| - '!ci/test_self_hosted_service.sh' | ||
| - '!ci/test_wheel*.sh' | ||
| - '!container-builder/**' | ||
| - '!helmchart/**' | ||
|
Member
Author
There was a problem hiding this comment. This directory is called |
||
| - '!ngc/**' | ||
|
Comment on lines
-128
to
-130
Member
Author
There was a problem hiding this comment. These directories no longer exist in the repo. |
||
| - '!sonar-project.properties' | ||
| - '!sonarqube/**' | ||
| - '!ucf/**' | ||
| - '!utilities/**' | ||
| test_cpp: | ||
| - '**' | ||
| - '!CONTRIBUTING.md' | ||
| - '!README.md' | ||
| - '!.ai/**' | ||
| - '!.coderabbit.yaml' | ||
| - '!.github/AGENTS.md' | ||
| - '!.github/CODE_OF_CONDUCT.md' | ||
| - '!.github/CODEOWNERS' | ||
| - '!.github/ISSUE_TEMPLATE/**' | ||
| - '!.github/PULL_REQUEST_TEMPLATE.md' | ||
| - '!.github/SECURITY.md' | ||
| - '!.github/.ai/**' | ||
| - '!.github/.coderabbit_review_guide.md' | ||
| - '!.github/agents/**' | ||
| - '!.github/copy-pr-bot.yaml' | ||
| - '!.github/ops-bot.yaml' | ||
| - '!.pre-commit-config.yaml' | ||
| - '!ci/build_docs.sh' | ||
| - '!ci/build_python.sh' | ||
| - '!ci/build_wheel*.sh' | ||
| - '!ci/check_style.sh' | ||
| - '!ci/release/**' | ||
| - '!ci/test_python.sh' | ||
| - '!ci/test_self_hosted_service.sh' | ||
| - '!ci/test_wheel*.sh' | ||
| - '!container-builder/**' | ||
| - '!docs/**' | ||
| - '!helmchart/**' | ||
| - '!img/**' | ||
| - '!ngc/**' | ||
| - '!notebooks/**' | ||
| - '!python/**' | ||
| - '!sonar-project.properties' | ||
| - '!sonarqube/**' | ||
| - '!ucf/**' | ||
| - '!utilities/**' | ||
| test_python_conda: | ||
| - '**' | ||
| - '!CONTRIBUTING.md' | ||
| - '!README.md' | ||
| - '!.ai/**' | ||
| - '!.coderabbit.yaml' | ||
| - '!.github/AGENTS.md' | ||
| - '!.github/CODE_OF_CONDUCT.md' | ||
| - '!.github/CODEOWNERS' | ||
| - '!.github/ISSUE_TEMPLATE/**' | ||
| - '!.github/PULL_REQUEST_TEMPLATE.md' | ||
| - '!.github/SECURITY.md' | ||
| - '!.github/.ai/**' | ||
| - '!.github/.coderabbit_review_guide.md' | ||
| - '!.github/agents/**' | ||
| - '!.github/copy-pr-bot.yaml' | ||
| - '!.github/ops-bot.yaml' | ||
| - '!.pre-commit-config.yaml' | ||
| - '!ci/build_docs.sh' | ||
| - '!ci/build_wheel*.sh' | ||
| - '!ci/check_style.sh' | ||
| - '!ci/release/**' | ||
| - '!ci/test_self_hosted_service.sh' | ||
| - '!ci/test_wheel*.sh' | ||
| - '!container-builder/**' | ||
| - '!docs/**' | ||
| - '!helmchart/**' | ||
| - '!img/**' | ||
| - '!ngc/**' | ||
| - '!notebooks/**' | ||
|
Member
Author
There was a problem hiding this comment. I'm hoping the But please do break it down into more-specific groups if you feel that's doable! The more unnecessary CI runs we can save, the better 😁 |
||
| - '!sonar-project.properties' | ||
| - '!sonarqube/**' | ||
| - '!ucf/**' | ||
| - '!utilities/**' | ||
| test_python_wheels: | ||
| - '**' | ||
| - '!CONTRIBUTING.md' | ||
| - '!README.md' | ||
| - '!.ai/**' | ||
| - '!.coderabbit.yaml' | ||
| - '!.github/AGENTS.md' | ||
| - '!.github/CODE_OF_CONDUCT.md' | ||
| - '!.github/CODEOWNERS' | ||
| - '!.github/ISSUE_TEMPLATE/**' | ||
| - '!.github/PULL_REQUEST_TEMPLATE.md' | ||
| - '!.github/SECURITY.md' | ||
| - '!.github/.ai/**' | ||
| - '!.github/.coderabbit_review_guide.md' | ||
| - '!.github/agents/**' | ||
| - '!.github/copy-pr-bot.yaml' | ||
| - '!.github/ops-bot.yaml' | ||
| - '!.pre-commit-config.yaml' | ||
| - '!ci/build_cpp.sh' | ||
| - '!ci/build_docs.sh' | ||
| - '!ci/build_python.sh' | ||
| - '!ci/check_style.sh' | ||
| - '!ci/release/**' | ||
| - '!ci/run_ctests.sh' | ||
| - '!ci/test_python.sh' | ||
| - '!conda/**' | ||
| - '!container-builder/**' | ||
| - '!helmchart/**' | ||
| - '!img/**' | ||
| - '!ngc/**' | ||
| - '!notebooks/**' | ||
| - '!sonar-project.properties' | ||
| - '!sonarqube/**' | ||
| - '!ucf/**' | ||
| - '!utilities/**' | ||
| checks: | ||
| secrets: inherit | ||
| uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@main | ||
|
|
@@ -187,7 +266,7 @@ jobs: | |
| conda-cpp-tests: | ||
| needs: [conda-cpp-build, changed-files, compute-matrix-filters] | ||
| uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-tests.yaml@main | ||
| if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_cpp | ||
| with: | ||
| build_type: pull-request | ||
| script: ci/test_cpp.sh | ||
|
|
@@ -210,7 +289,7 @@ jobs: | |
| conda-python-tests: | ||
| needs: [conda-python-build, changed-files, compute-matrix-filters] | ||
| uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@main | ||
| if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_conda | ||
|
Member
Author
There was a problem hiding this comment. These skips have all been disabled for the last year: https://github.com/rapidsai/cuopt/pull/2244 From that PR, I'm really not sure why or what the issue was. But either way, that's a year of running more CI than necessary, which is a waste of money and time. Hopefully we can re-enable this now... it'd help get changes integrated faster and reduce |
||
| with: | ||
| run_codecov: false | ||
| build_type: pull-request | ||
|
|
@@ -224,9 +303,10 @@ jobs: | |
| script-env-secret-3-key: CUOPT_AWS_SECRET_ACCESS_KEY | ||
| script-env-secret-3-value: ${{ secrets.CUOPT_AWS_SECRET_ACCESS_KEY }} | ||
| docs-build: | ||
| needs: [conda-python-build, changed-files] | ||
| secrets: inherit | ||
| uses: rapidsai/shared-workflows/.github/workflows/custom-job.yaml@main | ||
| if: fromJSON(needs.changed-files.outputs.changed_file_groups).build_docs | ||
| with: | ||
| build_type: pull-request | ||
| node_type: "gpu-l4-latest-1" | ||
|
|
@@ -271,7 +351,7 @@ jobs: | |
| wheel-tests-cuopt: | ||
| needs: [wheel-build-cuopt, wheel-build-cuopt-mps-parser, wheel-build-cuopt-sh-client, changed-files, compute-matrix-filters] | ||
| uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@main | ||
| if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels | ||
| with: | ||
| build_type: pull-request | ||
| script: ci/test_wheel_cuopt.sh | ||
|
|
@@ -311,7 +391,7 @@ jobs: | |
| wheel-tests-cuopt-server: | ||
| needs: [wheel-build-cuopt, wheel-build-cuopt-server, changed-files, compute-matrix-filters] | ||
| uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@main | ||
| if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels | ||
| with: | ||
| build_type: pull-request | ||
| script: ci/test_wheel_cuopt_server.sh | ||
|
|
@@ -327,7 +407,7 @@ jobs: | |
| needs: [wheel-build-cuopt, wheel-build-cuopt-server, changed-files] | ||
| secrets: inherit | ||
| uses: ./.github/workflows/self_hosted_service_test.yaml | ||
| if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels | ||
| with: | ||
| build_type: pull-request | ||
| script: ci/test_self_hosted_service.sh | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs builds use GPU runners. Those runners are scarce, so it's worth skipping those jobs when they're not necessary (like when a PR only changes the Helm chart).