ci: fix unbound CONDA_PREFIX in test_doc_examples.sh#1462
Draft
ramakrishnap-nv wants to merge 2 commits into
Draft
ci: fix unbound CONDA_PREFIX in test_doc_examples.sh#1462ramakrishnap-nv wants to merge 2 commits into
ramakrishnap-nv wants to merge 2 commits into
Conversation
CONDA_PREFIX is unset in wheel test environments. Use \${CONDA_PREFIX:-}
so the variable defaults to empty rather than tripping set -o nounset.
The search loop already skips empty entries, so behavior is unchanged
in conda environments.
Fixes #1459.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ramakrishnap-nv
added
bug
Collaborator
Author
|
/ok to test 60ef2ce |
The MIP C examples directory had .c files but no Makefile, causing test_doc_examples.sh to mark all 2 examples as failed. The convex examples Makefile is generic (auto-discovers .c files) so copy it here. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
${CONDA_PREFIX:-}so the variable defaults to empty when unset (wheel environments). The search loop already skips empty entries, so conda behavior is unchanged. Fixes #1459.