tests: retire correctness/regression tests covered by C++ gtests#1461
Open
ramakrishnap-nv wants to merge 2 commits into
Open
tests: retire correctness/regression tests covered by C++ gtests#1461ramakrishnap-nv wants to merge 2 commits into
ramakrishnap-nv wants to merge 2 commits into
Conversation
Remove 5 Python tests whose only role was asserting specific solver output values. Correctness for these code paths is already covered by C++ gtests; the Python suite should focus on API behavior. - Delete test_qp.py::test_solver — QP objective/variable values covered by cpp/tests/linear_programming/qp_test.cu; QP API covered by test_python_API.py quadratic_objective/matrix tests - Remove test_solver.py::test_solomon — VRPTW objective/vehicle count; routing API covered by test_vehicle_properties.py - Remove test_solver.py::test_pdptw — PDP objective value; pickup- delivery pairs API covered by test_vehicle_properties.py::test_heterogenous_breaks - Remove test_distance_engine.py::test_compute_cost_matrix — numerical matrix match against reference CSV; compute_cost_matrix API covered by test_compute_waypoint_sequence_* tests - Remove test_distance_engine.py::test_compute_shortest_path_costs — exact matrix match; error-path coverage kept in test_target_locations_validity Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe quadratic-programming test module was removed, and two routing test modules were pruned. The routing files also drop unused imports and delete the shortest-path, Solomon, and PDPTW test cases. ChangesCuOpt test module removals
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 5 Python tests that assert specific solver output values. The Python test suite should cover API behavior; correctness and regression coverage for these cases already exists in the C++ gtest suite.
Removed tests:
test_qp.py::test_solver— asserted QP objective −32 and variable valuesx1=4, x2=2. QP correctness covered bycpp/tests/linear_programming/qp_test.cu; QP API covered bytest_python_API.py::test_quadratic_objective_*tests.test_solver.py::test_solomon— asserted VRPTW objective ~1087.15 and vehicle count ≤12. Routing API covered bytest_vehicle_properties.py.test_solver.py::test_pdptw— asserted PDP objective 13.0. Pickup-delivery pairs API covered bytest_vehicle_properties.py::test_heterogenous_breaks.test_distance_engine.py::test_compute_cost_matrix— numerical matrix match against reference CSVs.compute_cost_matrixAPI covered by the kepttest_compute_waypoint_sequence_*tests.test_distance_engine.py::test_compute_shortest_path_costs— exact matrix match against hardcoded expected values. Error-path coverage forcompute_shortest_path_costsretained intest_target_locations_validity.Also removes helper functions and imports that were only used by the deleted tests.