CI: Harden prior-branch artifact lookup - #2643
Draft
rwgk wants to merge 1 commit into
Draft
Conversation
Sort completed branch runs explicitly and choose the newest successful run whose required artifacts are still available. Validate bindings and metapackage artifacts at all prior-branch download sites, and cover fallback and compatibility behavior with standalone tests.
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 8a95bec |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2642.
CUDA Python CI reuses
cuda.bindingswheel artifacts from the configured prior-major branch when it builds and tests the combinedcuda.corewheel. The existing lookup trusted the first successful run returned bygh run listwithout verifying that the artifacts required by the requesting matrix row were present and unexpired.This change makes branch-mode lookup choose the newest usable run from a bounded candidate set:
--artifactpatterns and require every pattern to match an unexpired artifact in the same run;--head-shaoutput.This intentionally does not eliminate the possibility that GitHub's server-side branch filter returns a stale or incomplete bounded candidate set; that broader lookup redesign remains outside #2642.
Testing
TestVenv/bin/python -m pytest -v --noconftest ci/tools/tests/test_lookup_run_id.py(4 passed)bash -n ci/tools/lookup-run-idshellcheck ci/tools/lookup-run-idpre-commit run --all-filesChecklist