ci: run released cuda-core compat on bindings PRs (#2449) - #2638
Open
atiaomar1978-hub wants to merge 3 commits into
Open
ci: run released cuda-core compat on bindings PRs (#2449)#2638atiaomar1978-hub wants to merge 3 commits into
atiaomar1978-hub wants to merge 3 commits into
Conversation
Wire the existing nightly-cuda-core test mode into PR CI when cuda_bindings or related paths change, and add guardrail tests so the workflow wiring stays aligned with the nightly jobs. Signed-off-by: Omar Atie <atiaomar1978@gmail.com>
Contributor
nightly-cuda-core still needs PR-built pathfinder/bindings wheels; only disable standard cuda-core and meta-package pytest runs. Signed-off-by: Omar Atie <atiaomar1978@gmail.com>
Apply ruff format to test_ci_pr_cuda_core_compat.py for pre-commit.ci. Signed-off-by: Omar Atie <atiaomar1978@gmail.com>
Contributor
Author
|
pre-commit.ci fix: Applied Review follow-up: Also fixed the wheel-download flags — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-cuda-core-linux-64to PR CI (ci.yml), reusing the existingnightly-cuda-coretest mode from CI: nightly-cuda-core + nightly-numba-cuda-mlir + PTDS fix #2283detect-changesflags bindings-related path changes (cuda_bindings, cuda_pathfinder, shared infra, test helpers)cuda-corefrom PyPI, then executes the released tag's test suitechecksaggregator with conditional expectations (success when bindings change, skipped otherwise)ci/tools/tests/test_ci_pr_cuda_core_compat.pyFixes #2449
Test plan
pytest -v --noconftest ci/tools/tests/test_ci_pr_cuda_core_compat.py(6 passed locally)test-cuda-core-linux-64runs on this PR (touches.github/workflows/ci.yml→ shared infra →test_bindings=true)checksaggregator passes with the new conditional gateMade with Cursor