Skip to content

fix(cuda.core): explicit exception chaining in GB_callback cleanup path #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdboom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cuda.core): explicit exception chaining in GB_callback cleanup path #2610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cuda_core/cuda/core/graph/_graph_builder.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,11 +931,14 @@ cdef inline void GB_callback(
if fail_tail_discovery_for_testing:
raise RuntimeError("forced capture tail discovery failure")
host_node = _capture_tail_node(c_stream)
except:
except BaseException as orig_exc:
# CUDA added the callback, but its node cannot be identified.
# Retain its owners anonymously to prevent dangling pointers.
commit_status = graph_commit_attachment(prepared, NULL)
HANDLE_RETURN(commit_status)
try:
HANDLE_RETURN(commit_status)
except Exception as commit_exc:
raise commit_exc from orig_exc
raise
HANDLE_RETURN(graph_commit_attachment(prepared, host_node))

Expand Down
Loading