-
Notifications
You must be signed in to change notification settings - Fork 279
Add persistent program cache for Program.compile #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cpcloud
wants to merge
34
commits into
NVIDIA:main
Choose a base branch
from
cpcloud:persistent-program-cache-178
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
d4a178c
feat(core.utils): persistent program cache
cpcloud b914f54
feat(core): Program.compile(cache=...) convenience wrapper
cpcloud e5ad304
refactor(core.utils): import program cache eagerly, fix ruff findings
cpcloud 29b973b
docs(core): nest Program caches under CUDA compilation toolchain
cpcloud 7e4f8ed
docs(core.utils): nudge cache callers toward close()
cpcloud d201703
docs(core.utils): teach cache examples with public ObjectCode API
cpcloud b93110b
feat(core): require Program.compile(cache=...) to be a ProgramCacheRe…
cpcloud 97a526a
test(core): mock driver_version to keep _can_load_generated_ptx as cpdef
cpcloud fee1941
docs(core): note cache hits do not write to logs
cpcloud f54c6fc
fix(core.utils): cache _LinkerBackend driver decision per key call
cpcloud f24c67b
fix(core): lowercase target_type in Program.compile and cache key
cpcloud 365b1f1
refactor(core.utils): collapse _LINKER_RELEVANT_FIELDS into _LINKER_F…
cpcloud af57edb
fix(core.utils): contextual error when path-backed ObjectCode vanishes
cpcloud 569e43a
docs(core): clarify cache= vs ProgramOptions.no_cache independence
cpcloud fbc1b4f
test(core.utils): tighten multiprocess cache assertions
cpcloud 888fa82
test(core.utils): add InMemoryProgramCache thread test and FileStream…
cpcloud 67306c6
refactor(core.utils): drop dead empty-key branch in _path_for_key
cpcloud e472ff0
perf(core.utils): drop redundant stat in FileStreamProgramCache.__len__
cpcloud 943010f
feat(core.utils): reject max_size_bytes=0 in cache backends
cpcloud c9c7daf
docs(core.utils): note ptxas_options order is intentionally significant
cpcloud af40133
docs(core.utils): document the _keys.py <-> _program.pyx import contract
cpcloud 70989e3
docs(core.utils): note options.name double-hash on PTX is intentional
cpcloud 871771c
docs(core.utils): document burst-write over-eviction trade-off
cpcloud 3621362
docs(core): explain why Program.compile cache decode is provably safe
cpcloud 2e3c080
refactor(core.utils): extract _stat_key for the four stat-guarded paths
cpcloud 9037d77
refactor(core.utils): collapse Windows sharing-retry loops
cpcloud 57a72fd
fix(test): walk sharded entries dir in FileStream overwrite assertion
cpcloud 69f6438
fix(test): collapse nested with into a single contextmanager group (S…
cpcloud c6aaaa7
fix(core.utils): keep path-backed ObjectCode error message Windows-fr…
cpcloud 547d3f3
perf(core.utils): track FileStream cache size incrementally
cpcloud 4aaca63
test(core.utils): drop SUPPORTED_TARGETS cross-check
cpcloud 8345735
refactor(core.utils): idiomatic with-as on os.scandir, yield from inner
cpcloud b6a2590
refactor(core.utils): extract _iter_tmp_entries and _sum_tmp_sizes
cpcloud 19d7cf7
fix(core.utils): clamp tracked size at zero on __delitem__
cpcloud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| from cuda.core._memoryview import ( | ||
| StridedMemoryView, | ||
| args_viewable_as_strided_memory, | ||
| ) | ||
| from cuda.core.utils._program_cache import ( | ||
| FileStreamProgramCache, | ||
| InMemoryProgramCache, | ||
| ProgramCacheResource, | ||
| make_program_cache_key, | ||
| ) | ||
|
|
||
| __all__ = [ | ||
| "FileStreamProgramCache", | ||
| "InMemoryProgramCache", | ||
| "ProgramCacheResource", | ||
| "StridedMemoryView", | ||
| "args_viewable_as_strided_memory", | ||
| "make_program_cache_key", | ||
| ] |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: I forgot that we already have a folder for collecting utils: How about we move the program cache files to there? Say, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Persistent program cache for cuda.core. | ||
|
|
||
| Public surface: | ||
|
|
||
| * :class:`ProgramCacheResource` -- bytes-in / bytes-out ABC. | ||
| * :class:`InMemoryProgramCache` -- thread-safe LRU dict-backed cache. | ||
| * :class:`FileStreamProgramCache` -- atomic, multi-process directory cache. | ||
| * :func:`make_program_cache_key` -- key derivation for arbitrary | ||
| ``Program`` configurations. | ||
|
|
||
| The package is split into submodules by concern. Tests that need to | ||
| monkeypatch internals (Windows flag, version probes, helpers, ...) | ||
| should reach into the owning submodule (e.g. | ||
| ``_program_cache._file_stream._IS_WINDOWS``, | ||
| ``_program_cache._keys._linker_backend_and_version``) rather than the | ||
| package object: the symbols re-exported here are only convenience | ||
| aliases and don't intercept calls within the submodules. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from ._abc import ProgramCacheResource | ||
| from ._file_stream import FileStreamProgramCache | ||
| from ._in_memory import InMemoryProgramCache | ||
| from ._keys import make_program_cache_key | ||
|
|
||
| __all__ = [ | ||
| "FileStreamProgramCache", | ||
| "InMemoryProgramCache", | ||
| "ProgramCacheResource", | ||
| "make_program_cache_key", | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: I need to address this after 1.0 is out, xref: cupy/cupy#9801