-
Notifications
You must be signed in to change notification settings - Fork 253
Fix PinnedMemoryResource IPC NUMA ID derivation #1699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andy-Jost
wants to merge
8
commits into
NVIDIA:main
Choose a base branch
from
Andy-Jost:refactor-mempool-hierarchy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+742
−378
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
069bdaa
Refactor _MemPool hierarchy: separate shared pool machinery from devi…
Andy-Jost 61810bd
Merge remote-tracking branch 'origin/main' into refactor-mempool-hier…
Andy-Jost e55a26b
Fix PinnedMemoryResource IPC to derive NUMA ID from active device (#1…
Andy-Jost 2902578
Add preferred_location_type option and query property to ManagedMemor…
Andy-Jost 2dd3d1a
Merge remote-tracking branch 'origin/main' into refactor-mempool-hier…
Andy-Jost c7f85ff
Remove redundant Python-side peer access cleanup; fix peer access tests
Andy-Jost 4c36462
Merge origin/main into refactor-mempool-hierarchy
Andy-Jost 629e142
Merge branch 'main' into refactor-mempool-hierarchy
Andy-Jost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| from cuda.core._memory._memory_pool cimport _MemPool | ||
|
|
||
|
|
||
| cdef class ManagedMemoryResource(_MemPool): | ||
| pass | ||
| cdef: | ||
| str _pref_loc_type | ||
| int _pref_loc_id |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like something that should almost certainly never be invoked in
__dealloc__. It's reading from and writing to the Python object whose__dealloc__method is being called.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yeah this was a mess. I removed all peer-access-clearing logic from Python. The real problem was that certain tests were using the default memory pool, which is persistent and should keep its peer access settings. Those tests incorrectly assumed the beginning state should be "no peer access." I updated those to simply use fresh pools.