Open
Conversation
Contributor
Contributor
Author
|
pre-commit.ci autofix |
Contributor
Author
|
/ok to test 129a571 |
Andy-Jost
added
enhancement
Collaborator
|
/ok to test 8b1fb02 |
Collaborator
|
(trying to help this over the finish line while our runners are not so busy) |
|
leofang
reviewed
Mar 7, 2026
Comment on lines
653
to
654
| if isinstance(module_source, str): | ||
| # Textual LLVM IR - encode to UTF-8 bytes | ||
| module_source = module_source.encode("utf-8") |
Member
There was a problem hiding this comment.
nitpick: I assume we could move the str->bytes conversion to earlier (perhaps do an in-place change in _prepare_nvvm_options_impl). Not a blocker!
leofang
approved these changes
Mar 7, 2026
Member
|
Thanks @abhilash1910! Could you check the test failure? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked to #1218 and comment: #1218
Refactor the option validation inside ProgramOptions init rather than Program_init.
cc @leofang @rwgk