Forward packed QKV and normalization kind for APB - #299
Open
Supernova-45 wants to merge 3 commits into
Open
Conversation
Supernova-45
marked this pull request as ready for review
August 9, 2026 19:59
Collaborator
Author
|
@greptileai review @coderabbitai review |
Collaborator
Author
|
Final review disposition:
Ready for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cuequivariance_torch.attention_pair_biasAPI to the ops backend.norm_kindcontract while preservinglayer_normas the public default.remains compatible with an older ops wheel; explicit RMSNorm still requires
backend support.
This is public-API plumbing only. It does not change kernels, routing policy,
or behavior for existing callers that do not use the new options.
Motivation
RFD4's production geometry uses a packed QKV projection and RMSNorm. Without
these arguments in the public wrapper, the integration can only reach the
optimized APB backend by calling the ops package directly.
Validation
3561046(clean).1 passed.default LayerNorm path works when the installed ops backend lacks both new
keywords.
3561137at public head
6fdca1d, RFD4 heada5f4cf5, and backend head462e9ad2.The actual RFD4 class compiled to
cuequivariance.apb_flash_forward; atB=8/N=384 it measured 1.361x over compiled-native RMSNorm with output
max-absolute error
4.88e-4and all-gradient max-absolute error2.74e-7.Backend implementation and qualification: kernelcatcher MR !686.
Integration consumer: baker-laboratory/RFD4-Proteina-dev#224.