Add support for roaring bitmaps with run containers and fewer than fo… #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleeepyjack
added
type: feature request
PointKernel
approved these changes
Jan 21, 2026
Member
PointKernel
left a comment
PointKernel
left a comment
There was a problem hiding this comment.
@sleeepyjack Is there a GitHub issue or discussion we can link to for reference on this fix? I don’t fully follow the details here, but I trust that your changes are valid. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a previously omitted edge case of the Roaring bitmap format spec. If a serialized 32-bit roaring bitmap contains run containers but has fewer than 4 containers in total, the spec demands omitting the container offset array and calculate the offsets on-the-fly.