Update NVBench#9223
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
SummaryThis pull request updates the NVBench dependency to a newer version by updating the commit hash pinned in the CMake configuration. Changescmake/CCCLGetDependencies.cmake
The update brings in a new NVBench release that introduces the WalkthroughThe NVBench dependency pin in the CMake configuration was updated to a new commit hash. The CCCL_NVBENCH_SHA cache variable in cmake/CCCLGetDependencies.cmake was changed to reference a different NVBench repository state. ChangesNVBench dependency pin
Comment |
😬 CI Workflow Results🟥 Finished in 3h 57m: Pass: 98%/500 | Total: 11d 20h | Max: 3h 56m | Hits: 49%/2210920See results here. |
every now and then we update the SHA in NVBench. Not sure if there is a criterion but newest NVBench introduces
--stopping-criterion sample-countwhich is very useful for my PDL work so why not update again.