Skip to content

Update NVBench#9223

Open
gonidelis wants to merge 1 commit into
NVIDIA:mainfrom
gonidelis:update_nvbench_sha
Open

Update NVBench#9223
gonidelis wants to merge 1 commit into
NVIDIA:mainfrom
gonidelis:update_nvbench_sha

Conversation

@gonidelis
Copy link
Copy Markdown
Member

every now and then we update the SHA in NVBench. Not sure if there is a criterion but newest NVBench introduces --stopping-criterion sample-count which is very useful for my PDL work so why not update again.

@gonidelis gonidelis requested a review from a team as a code owner June 3, 2026 00:06
@gonidelis gonidelis requested a review from alliepiper June 3, 2026 00:06
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Jun 3, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Jun 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8c5959ef-d62e-4c16-841b-592056d56fb2

📥 Commits

Reviewing files that changed from the base of the PR and between 5a4ab0e and fda40b9.

📒 Files selected for processing (1)
  • cmake/CCCLGetDependencies.cmake

Note: CodeRabbit is enabled on this repository as a convenience for maintainers
and contributors. Use your best judgment when considering its review comments and
suggestions — a suggested change may be inadequate, unnecessary, or safe to ignore.
Contributors are not expected to address every comment. Human reviews are what
ultimately matter for merging.

Summary

This pull request updates the NVBench dependency to a newer version by updating the commit hash pinned in the CMake configuration.

Changes

cmake/CCCLGetDependencies.cmake

  • Updated CCCL_NVBENCH_SHA cache variable from 373970323f3e2a3995761ea682ca64dfcbdd1e26 to ee4b9f0963387334db194663134dc6ef714004c4

The update brings in a new NVBench release that introduces the --stopping-criterion sample-count command-line option, which is useful for the author's PDL work.

Walkthrough

The NVBench dependency pin in the CMake configuration was updated to a new commit hash. The CCCL_NVBENCH_SHA cache variable in cmake/CCCLGetDependencies.cmake was changed to reference a different NVBench repository state.

Changes

NVBench dependency pin

Layer / File(s) Summary
NVBench commit hash pin
cmake/CCCLGetDependencies.cmake
CCCL_NVBENCH_SHA cache variable updated to a new NVBench commit hash used by the cccl_get_nvbench CPM dependency fetch.

Comment @coderabbitai help to get the list of available commands and usage tips.

@gonidelis gonidelis enabled auto-merge (squash) June 3, 2026 00:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

😬 CI Workflow Results

🟥 Finished in 3h 57m: Pass: 98%/500 | Total: 11d 20h | Max: 3h 56m | Hits: 49%/2210920

See results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

4 participants