Skip to content

fix: comment typo 'mas' -> 'mask' in two TODOs #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: comment typo 'mas' -> 'mask' in two TODOs #3372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/jax/test_fused_attn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@ def test_forward(self):

customcall_args = [
# Put test data onto each GPU for distributed.
# TODO(mgoldfarb-nvidia): We will need to add reordering for bias, mas and
# TODO(mgoldfarb-nvidia): We will need to add reordering for bias, mask and
# THD params once we support those features on CP.
jax.device_put(self.cp_reorder_fn(self.q), self.qkvo_sharding),
jax.device_put(self.cp_reorder_fn(self.k), self.qkvo_sharding),
Expand Down Expand Up @@ -1089,7 +1089,7 @@ def grad_func(
self.dropout_rng,
]
customcall_args = [
# TODO(mgoldfarb-nvidia): We will need to add reordering for bias, mas and
# TODO(mgoldfarb-nvidia): We will need to add reordering for bias, mask and
# THD params once we support those features on CP.
jax.device_put(self.cp_reorder_fn(self.q), self.qkvo_sharding),
jax.device_put(self.cp_reorder_fn(self.k), self.qkvo_sharding),
Expand Down