[None][infra] Waive 1 failed cases for main in pre-merge 53139 - #17517
Conversation
Bug(s): 6594241 Requested by: @pranav-nvidia Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "Waive only" |
WalkthroughThe integration waiver list now skips the DGX B200 disaggregated GPT-OSS 120B test and references NVBugs issue 6594241. ChangesGPT-OSS integration test waiver
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/test_lists/waives.txt (1)
1-1: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winHandle SPDX comments before adding the header.
parse_and_validate_test_listignores#lines, butverify_waive_listprocesses every non-empty line. An SPDX header would be reported as a non-existent test. Update the raw waiver checks to skip comments, then add the 2026 NVIDIA SPDX header.Coverage:
tests/integration/test_lists/waives.txtadds one waiver and removes none. No test functions ortest-db/orqa/entries changed. CBTS coverage data is unavailable. Verdict: needs follow-up.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 1, Update verify_waive_list to ignore comment lines beginning with #, matching parse_and_validate_test_list behavior, then add the 2026 NVIDIA SPDX header to tests/integration/test_lists/waives.txt while preserving the existing waiver entry.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 1: Update verify_waive_list to ignore comment lines beginning with #,
matching parse_and_validate_test_list behavior, then add the 2026 NVIDIA SPDX
header to tests/integration/test_lists/waives.txt while preserving the existing
waiver entry.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 572471ae-0e5e-4742-a33f-397c5560e570
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
brnguyen2
left a comment
There was a problem hiding this comment.
Approving — the comments below are optional touch-ups, not blockers.
Entry is well-formed and correctly placed: the ID matches tests/integration/test_lists/test-db/l0_dgx_b200.yml:51 verbatim, and line 189 keeps the file's sort order. The test also appears in tests/integration/test_lists/qa/llm_function_core.txt:874; confirm the QA list honors waives.txt if that run matters here.
|
/bot skip --comment "Waive only" |
|
PR_Github #65388 [ skip ] triggered by Bot. Commit: |
|
PR_Github #65388 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @pranav-nvidia)
Target branch:
mainBug(s): 6594241
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
test_disaggregated_gpt_oss_120b_harmony[gpt_oss/gpt-oss-120b].6594241.QA Engineer Review
test-db/orqa/files.tests/integration/test_lists/waives.txt.