Skip to content

[None][fix] fix oom - #17486

Merged
xinhe-nv merged 4 commits into
NVIDIA:mainfrom
xinhe-nv:fix-oom
Aug 11, 2026
Merged

[None][fix] fix oom#17486
xinhe-nv merged 4 commits into
NVIDIA:mainfrom
xinhe-nv:fix-oom

Conversation

@xinhe-nv

@xinhe-nv xinhe-nv commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Updated free_gpu_memory_fraction in two integration tests.
  • Set the DeepSeek-V3-Lite FP8 block-scale multi-GPU test to 0.6.
  • Set the Nemotron-Ultra V3 MARLIN test to 0.5.
  • The values are valid fractional settings.
  • The change is limited to test configuration.
  • No public API, error handling, or unrelated configuration changes were identified.

QA Engineer Review

  • Modified two test configurations:
    • DeepSeek-V3-Lite FP8 block-scale multi-GPU integration test.
    • Nemotron-Ultra V3 MARLIN integration test.
  • No test-list changes were reported.
  • Test-list coverage could not be verified from the available change summary.
  • Verdict: needs follow-up.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
@xinhe-nv
xinhe-nv marked this pull request as ready for review August 11, 2026 06:21
@xinhe-nv
xinhe-nv requested review from a team as code owners August 11, 2026 06:21
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Two PyTorch accuracy tests now use lower KV-cache memory fractions. One test changes an existing value, and the other adds an explicit value.

Changes

KV-cache test configuration

Layer / File(s) Summary
Adjust test KV-cache fractions
tests/integration/defs/accuracy/test_llm_api_pytorch.py
The DeepSeek-V3-Lite test changes free_gpu_memory_fraction from 0.75 to 0.6. The Nemotron-Ultra V3 test sets it to 0.5.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: larryxfly, qijune, tburt-nv

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The description omits the issue, solution, and test coverage details required by the template. Add a brief issue and solution summary, list the relevant tests, and complete the applicable checklist items.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title identifies a fix for out-of-memory errors, which matches the primary change to reduce GPU memory usage.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@xinhe-nv

xinhe-nv commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "only update free_gpu_memory_fraction value, test is pass on QA CI"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65239 [ skip ] triggered by Bot. Commit: 0bb8384 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65239 [ skip ] completed with state SUCCESS. Commit: 0bb8384
Skipping testing for commit 0bb8384

Link to invocation

@xinhe-nv
xinhe-nv merged commit d3cfe40 into NVIDIA:main Aug 11, 2026
13 checks passed
@xinhe-nv
xinhe-nv deleted the fix-oom branch August 11, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants