Skip to content

[None][fix] Use verified UCX environment on oci-aga - #17465

Open
chuangz0 wants to merge 1 commit into
NVIDIA:mainfrom
chuangz0:use_verfied_env_on_oci_aga
Open

[None][fix] Use verified UCX environment on oci-aga#17465
chuangz0 wants to merge 1 commit into
NVIDIA:mainfrom
chuangz0:use_verfied_env_on_oci_aga

Conversation

@chuangz0

@chuangz0 chuangz0 commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the oci-aga UCX environment with the validated transport set and IPv4 TCP priority.
  • Update the unit test expectation for the cluster-specific command.

Motivation

The previous environment variables could cause failures on the oci-aga cluster. The new environment variables have been validated on oci-aga without observed issues.

Testing

  • pytest -q tests/unittest/scripts/test_cluster_env.py (17 passed)
  • Pre-commit hooks passed during the signed commit.

Dev Engineer Review

  • Updated the oci-aga UCX configuration to use cuda_ipc,cuda_copy,sm,self,tcp.
  • Added UCX_TCP_AF_PRIO=inet for IPv4 TCP priority.
  • Removed the previous VF-specific transport exclusions and related settings.
  • The configuration values are consistent with the validated transport set.
  • The unit test expectation matches the new cluster command.
  • No public API or exported declaration changed.
  • Pre-commit hooks passed.

QA Engineer Review

  • Modified the cluster-specific expectation in tests/unittest/scripts/test_cluster_env.py.
  • No test functions were added, modified, or removed.
  • The test verifies the updated oci-aga-cs-001 UCX export.
  • The test passed as part of the 17 tests in tests/unittest/scripts/test_cluster_env.py.
  • No integration test-list coverage was reported.
  • Verdict: needs follow-up.

@chuangz0
chuangz0 marked this pull request as ready for review August 10, 2026 06:42
@chuangz0
chuangz0 requested review from a team as code owners August 10, 2026 06:42
@chuangz0
chuangz0 force-pushed the use_verfied_env_on_oci_aga branch from e75f450 to d5117ca Compare August 10, 2026 06:42
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4014f633-12bb-411c-a959-48e96e89b261

📥 Commits

Reviewing files that changed from the base of the PR and between 685a6c0 and d5117ca.

📒 Files selected for processing (2)
  • jenkins/scripts/perf/cluster_env.py
  • tests/unittest/scripts/test_cluster_env.py

Walkthrough

The OCI AGA UCX rule now uses CUDA and TCP transports with IPv4 priority. The corresponding cluster test expectation matches the new export.

Changes

OCI AGA UCX configuration

Layer / File(s) Summary
Update UCX transport rule and validation
jenkins/scripts/perf/cluster_env.py, tests/unittest/scripts/test_cluster_env.py
The oci-aga rule replaces VF-specific settings with cuda_ipc,cuda_copy,sm,self,tcp and UCX_TCP_AF_PRIO=inet. The cluster test checks the updated export.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: qijune

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix and the affected oci-aga UCX environment.
Description check ✅ Passed The description explains the change, motivation, and relevant test results; it provides sufficient coverage for the required sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@chuangz0

Copy link
Copy Markdown
Collaborator Author

/bot run

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
@chuangz0
chuangz0 force-pushed the use_verfied_env_on_oci_aga branch from d5117ca to 8976864 Compare August 11, 2026 06:36
@chuangz0

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65221 [ run ] triggered by Bot. Commit: 8976864 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65221 [ run ] completed with state FAILURE. Commit: 8976864
/LLM/main/L0_MergeRequest_PR pipeline #53006 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants