Skip to content

[None][chore] Default enable PDL for benchmoe - #17463

Open
leslie-fang25 wants to merge 1 commit into
NVIDIA:mainfrom
leslie-fang25:leslie/enable_PDL_for_benchmoe
Open

[None][chore] Default enable PDL for benchmoe#17463
leslie-fang25 wants to merge 1 commit into
NVIDIA:mainfrom
leslie-fang25:leslie/enable_PDL_for_benchmoe

Conversation

@leslie-fang25

@leslie-fang25 leslie-fang25 commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Enables PDL by setting TRTLLM_ENABLE_PDL to "1" in the BenchMOE worker environment.
  • The value is valid and the scope is limited to BenchMOE.
  • No public API or exported entity changed.

QA Engineer Review

  • No test functions were added, modified, or removed.
  • No test-list coverage entry was changed.
  • Verdict: needs follow-up because no CI or manual QA coverage data is available.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: leslief <leslief@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d05f46fb-fcaf-41c8-80c1-eec6021e3987

📥 Commits

Reviewing files that changed from the base of the PR and between 3bffdc3 and fc4106c.

📒 Files selected for processing (1)
  • tests/microbenchmarks/bench_moe/worker.py

Walkthrough

The MoE benchmark worker now enables PDL through its environment configuration.

Changes

MoE benchmark PDL

Layer / File(s) Summary
Enable PDL worker setting
tests/microbenchmarks/bench_moe/worker.py
The worker changes TRTLLM_ENABLE_PDL from "0" to "1".

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the template and checklist, but it provides no issue, solution, or test coverage details. Add a concise Description section that explains the change and add Test Coverage details for the BenchMOE configuration change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that PDL is enabled by default for BenchMOE and follows the required ticket and type format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@leslie-fang25

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64968 [ run ] triggered by Bot. Commit: fc4106c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64968 [ run ] completed with state SUCCESS. Commit: fc4106c
/LLM/main/L0_MergeRequest_PR pipeline #52799 completed with status: 'SUCCESS'

CI Report

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants