Skip to content

Add warning for unrestricted latency benchmarks - #17431

Open
Pritiks23 wants to merge 1 commit into
NVIDIA:mainfrom
Pritiks23:add-benchmark-runtime-warning
Open

Add warning for unrestricted latency benchmarks#17431
Pritiks23 wants to merge 1 commit into
NVIDIA:mainfrom
Pritiks23:add-benchmark-runtime-warning

Conversation

@Pritiks23

@Pritiks23 Pritiks23 commented Aug 7, 2026

Copy link
Copy Markdown

Summary

Adds a warning when neither --num_requests nor --duration is specified. The warning states that the full dataset will run and recommends setting an explicit limit.

Dev Engineer Review

  • The warning applies only when both benchmark limits are unset.
  • The change does not alter public APIs or benchmark behavior.
  • Python syntax validation passed.
  • No configuration or test-list files changed.

QA Engineer Review

No test changes.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • [ X] Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@Pritiks23
Pritiks23 requested a review from a team as a code owner August 7, 2026 20:52
@Pritiks23
Pritiks23 requested review from chenfeiz0326 and hyukn August 7, 2026 20:52
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 11647e49-e6c8-429d-ac2b-876498703f3f

📥 Commits

Reviewing files that changed from the base of the PR and between 4b69c59 and 9e8766e.

📒 Files selected for processing (1)
  • tensorrt_llm/bench/benchmark/low_latency.py

Walkthrough

The low-latency benchmark now warns when neither num_requests nor duration limits execution. The warning states that the full dataset will be processed and suggests using either limit.

Changes

Benchmark warning

Layer / File(s) Summary
Warn on unlimited runs
tensorrt_llm/bench/benchmark/low_latency.py
After CLI options are parsed, the benchmark warns when num_requests is nonpositive and duration is not provided.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding a warning for unrestricted latency benchmarks.
Description check ✅ Passed The description explains the problem and solution, documents syntax validation, and includes the required checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Pritiks23 <pritikavipin@gmail.com>
@Pritiks23
Pritiks23 force-pushed the add-benchmark-runtime-warning branch from 9e8766e to dfbc55d Compare August 7, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant