[https://nvbugs/6567065][fix] Unwaive some fixed cases - #17418
Conversation
|
/bot run --disable-fail-fast |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe integration test waiver list removes one configurable multi-GPU MoE skip and two duplicate Qwen3.5 35B FP8 weight-update skips. Related waiver entries remain. ChangesIntegration test waiver updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #64600 [ run ] triggered by Bot. Commit: |
|
PR_Github #64600 [ run ] completed with state
|
|
Removed the "ci: full pre-merge approved" label because @leslie-fang25 could not be verified as an active member of NVIDIA/trt-llm-ci-approvers. Ask a member of that team to apply it. |
brnguyen2
left a comment
There was a problem hiding this comment.
Approving — the comments below are optional touch-ups, not blockers.
Removals look right — all three failures share one root cause and the fix has landed, so the waivers are stale.
Two things:
- One removed line is tagged
https://nvbugs/6567066, not the 6567065 in the title. Worth mentioning it in the description and updating that bug too, so it doesn't get re-waived by someone tracking it separately. - All three tests only run in post-merge stages, so a plain
/bot runwon't exercise them. Please run with--stage-list "DGX_B200-4_GPUs-PyTorch-Ray-1, DGX_B200-4_GPUs-PyTorch-3"(or--extra-stage) before merging, and paste the result.
|
/bot run --disable-fail-fast --extra-stage "DGX_B200-4_GPUs-PyTorch-Ray-, DGX_B200-4_GPUs-PyTorch-" |
|
/bot run --disable-fail-fast --extra-stage "DGX_B200-4_GPUs-PyTorch-Ray-*, DGX_B200-4_GPUs-PyTorch-" |
|
/bot run --disable-fail-fast --extra-stage "DGX_B200-4_GPUs-PyTorch-Ray-, DGX_B200-4_GPUs-PyTorch-" |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
PR_Github #64916 [ run ] triggered by Bot. Commit: |
|
PR_Github #64917 [ run ] triggered by Bot. Commit: |
|
PR_Github #64916 [ run ] completed with state |
|
PR_Github #64918 [ run ] triggered by Bot. Commit: |
|
PR_Github/17418-35e2716 #64917 was force-killed by a newer pipeline run. |
|
/bot run --disable-fail-fast |
|
PR_Github #64922 [ run ] triggered by Bot. Commit: |
|
PR_Github #64918 [ run ] completed with state |
Signed-off-by: leslief <leslief@nvidia.com>
35e2716 to
3fd194b
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #64941 [ run ] triggered by Bot. Commit: |
|
PR_Github #64922 [ run ] completed with state |
|
PR_Github #64941 [ run ] completed with state |
|
All 3 cases |
Dev Engineer Review
tests/integration/test_lists/waives.txt.QA Engineer Review
tests/integration/test_lists/waives.txt.Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.