Skip to content

[https://nvbugs/6567065][fix] Unwaive some fixed cases - #17418

Merged
leslie-fang25 merged 1 commit into
NVIDIA:mainfrom
leslie-fang25:leslie/fix_6567065
Aug 10, 2026
Merged

[https://nvbugs/6567065][fix] Unwaive some fixed cases#17418
leslie-fang25 merged 1 commit into
NVIDIA:mainfrom
leslie-fang25:leslie/fix_6567065

Conversation

@leslie-fang25

@leslie-fang25 leslie-fang25 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Removed three obsolete entries from tests/integration/test_lists/waives.txt.
  • The change unwaives fixed cases for NVBug 6567065.
  • The remaining related skip entries are retained.
  • No public API or exported entity changes were made.
  • No correctness, performance, or error-handling regressions were identified.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt.
  • Removed one configurable multi-GPU MoE TRTLLM/FP8 block-scales entry.
  • Removed two duplicate Qwen3.5 35B FP8 weight-update entries.
  • No test code was added, modified, or removed.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@leslie-fang25

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: de537ef2-1ad3-4358-8b84-7ae4f1ba04ba

📥 Commits

Reviewing files that changed from the base of the PR and between 35e2716 and 3fd194b.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

The integration test waiver list removes one configurable multi-GPU MoE skip and two duplicate Qwen3.5 35B FP8 weight-update skips. Related waiver entries remain.

Changes

Integration test waiver updates

Layer / File(s) Summary
Remove obsolete waiver entries
tests/integration/test_lists/waives.txt
Removes the configurable multi-GPU MoE TRTLLM/FP8 block-scales skip and two duplicate Qwen3.5 35B FP8 weight-update skips. Retains the remaining related skips.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: qijune, yuanjingx87, yingguo-trt

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description leaves the required Description and Test Coverage sections empty and provides no issue, solution, or test details. Add a concise issue and solution summary, and list the relevant tests or CI coverage for the removed waivers.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format and clearly states that fixed cases are being unwaived.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64600 [ run ] triggered by Bot. Commit: 35e2716 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64600 [ run ] completed with state FAILURE. Commit: 35e2716
/LLM/main/L0_MergeRequest_PR pipeline #52462 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Removed the "ci: full pre-merge approved" label because @leslie-fang25 could not be verified as an active member of NVIDIA/trt-llm-ci-approvers. Ask a member of that team to apply it.

@brnguyen2 brnguyen2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — the comments below are optional touch-ups, not blockers.

Removals look right — all three failures share one root cause and the fix has landed, so the waivers are stale.

Two things:

  1. One removed line is tagged https://nvbugs/6567066, not the 6567065 in the title. Worth mentioning it in the description and updating that bug too, so it doesn't get re-waived by someone tracking it separately.
  2. All three tests only run in post-merge stages, so a plain /bot run won't exercise them. Please run with --stage-list "DGX_B200-4_GPUs-PyTorch-Ray-1, DGX_B200-4_GPUs-PyTorch-3" (or --extra-stage) before merging, and paste the result.

@leslie-fang25

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --extra-stage "DGX_B200-4_GPUs-PyTorch-Ray-, DGX_B200-4_GPUs-PyTorch-"

@leslie-fang25

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --extra-stage "DGX_B200-4_GPUs-PyTorch-Ray-*, DGX_B200-4_GPUs-PyTorch-"

@leslie-fang25

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast --extra-stage "DGX_B200-4_GPUs-PyTorch-Ray-, DGX_B200-4_GPUs-PyTorch-"

@leslie-fang25

Copy link
Copy Markdown
Collaborator Author

/bot help

@github-actions

Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Supports wildcard * for pattern matching (e.g., "*PerfSanity*" matches all stages containing PerfSanity). Examples: "A10-PyTorch-1, xxx", "PerfSanity". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label. Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Requires the ci: full pre-merge approved label on the PR (ask a member of NVIDIA/trt-llm-ci-approvers). Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline. Requires the ci: full pre-merge approved label on the PR (ask a member of NVIDIA/trt-llm-ci-approvers).

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline. Requires the ci: post-merge approved PR label applied by an active member of NVIDIA/trt-llm-ci-approvers. The approval label remains in place when new commits are pushed.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Supports wildcard * for pattern matching. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx", --extra-stage "Post-Merge". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label.

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64916 [ run ] triggered by Bot. Commit: 35e2716 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64917 [ run ] triggered by Bot. Commit: 35e2716 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64916 [ run ] completed with state ABORTED. Commit: 35e2716

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64918 [ run ] triggered by Bot. Commit: 35e2716 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github/17418-35e2716 #64917 was force-killed by a newer pipeline run.
L0 job information not available (job may not have been triggered yet).

Link to superseding invocation

@leslie-fang25

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64922 [ run ] triggered by Bot. Commit: 35e2716 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64918 [ run ] completed with state ABORTED. Commit: 35e2716

Link to invocation

Signed-off-by: leslief <leslief@nvidia.com>
@leslie-fang25

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64941 [ run ] triggered by Bot. Commit: 3fd194b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64922 [ run ] completed with state ABORTED. Commit: 35e2716

Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #64941 [ run ] completed with state SUCCESS. Commit: 3fd194b
/LLM/main/L0_MergeRequest_PR pipeline #52776 completed with status: 'SUCCESS'

CI Report

Link to invocation

@leslie-fang25

Copy link
Copy Markdown
Collaborator Author

All 3 cases test_configurable_moe_multi_gpu -k "TRTLLM and FP8_BLOCK_SCALES", test_llm_update_weights_multi_gpu.py::test_llm_update_weights_qwen35_35b_fp8 and test_llm_update_weights_multi_gpu.py::test_llm_partial_update_weights_qwen35_35b_fp8 pass on L0_MergeRequest_PR/52776

@leslie-fang25
leslie-fang25 merged commit 3bffdc3 into NVIDIA:main Aug 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants