Skip to content

[None][test] Add Kimi-K2.5 disaggregated GSM8K accuracy test#15617

Open
Shixiaowei02 wants to merge 1 commit into
NVIDIA:mainfrom
Shixiaowei02:dev/xiaoweis/kimi-k25-disagg-acc
Open

[None][test] Add Kimi-K2.5 disaggregated GSM8K accuracy test#15617
Shixiaowei02 wants to merge 1 commit into
NVIDIA:mainfrom
Shixiaowei02:dev/xiaoweis/kimi-k25-disagg-acc

Conversation

@Shixiaowei02

@Shixiaowei02 Shixiaowei02 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Description

This pull request adds a new integration test for the Kimi-K2.5 model with NVFP4 quantization, updates the GSM8K accuracy reference data, and ensures the new test is included in the test suite. The main changes are grouped below:

New integration test for Kimi-K2.5:

  • Added a new TestKimiK25 class in test_disaggregated_serving.py to test GSM8K accuracy for the moonshotai/Kimi-K2.5 model with NVFP4 quantization in a disaggregated server setup. This includes configuration for context and generation servers, and uses the launch_disaggregated_llm utility.

Test suite updates:

  • Registered the new test TestKimiK25::test_nvfp4 in the llm_function_core.txt test list to ensure it runs as part of the integration test suite.

Accuracy reference data update:

  • Updated gsm8k.yaml to add an entry for moonshotai/Kimi-K2.5 with NVFP4 quantization and the corresponding accuracy, aligning the reference data with the new test.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • New Features

    • Added a new integration accuracy test for a Kimi K2.5 model configuration.
    • Included the new test in the QA test list so it runs with the rest of the suite.
  • Bug Fixes

    • Expanded GSM8K accuracy coverage with an additional validated model/configuration entry.

Add TestKimiK25.test_nvfp4 to test_disaggregated_serving.py: a
disaggregated (ctx-TP4 + gen-TP4) GSM8K accuracy test for Kimi-K2.5
(NVFP4), modeled on the sibling TestKimiK2 disagg test. GSM8K runs the
text-only DeepSeek-V3 MLA path; trust_remote_code is set on both servers
since the checkpoint ships custom HF modeling code via auto_map.

The disagg harness resolves kv_cache_quant_algo=None, so add a bare
(NVFP4) GSM8K reference entry for moonshotai/Kimi-K2.5 alongside the
existing (NVFP4, FP8-KV) one (same accuracy), mirroring Kimi-K2-Thinking.
Register the test in qa/llm_function_core.txt.

Signed-off-by: Xiaowei Shi <39303645+Shixiaowei02@users.noreply.github.com>
@Shixiaowei02

Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 98f861ea-b27f-484f-9dcd-2a35c49ef2ca

📥 Commits

Reviewing files that changed from the base of the PR and between 70a7528 and cccaf96.

📒 Files selected for processing (3)
  • tests/integration/defs/accuracy/references/gsm8k.yaml
  • tests/integration/defs/accuracy/test_disaggregated_serving.py
  • tests/integration/test_lists/qa/llm_function_core.txt

📝 Walkthrough

Walkthrough

Adds a disaggregated serving accuracy test for moonshotai/Kimi-K2.5 using NVFP4 on GSM8K, records the matching accuracy reference, and adds the test to the QA selection list.

Changes

Kimi-K2.5 NVFP4 accuracy coverage

Layer / File(s) Summary
Test, reference, and QA wiring
tests/integration/defs/accuracy/test_disaggregated_serving.py, tests/integration/defs/accuracy/references/gsm8k.yaml, tests/integration/test_lists/qa/llm_function_core.txt
TestKimiK25.test_nvfp4 sets up disaggregated context and generation servers for GSM8K with NVFP4, gsm8k.yaml adds the NVFP4 accuracy value, and llm_function_core.txt adds the test entry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • xinhe-nv
  • jieli-matrix
  • QiJune
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and clearly describes the new Kimi-K2.5 disaggregated GSM8K accuracy test.
Description check ✅ Passed The description includes the change summary and checklist, but the Test Coverage section is left empty.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55727 [ run ] triggered by Bot. Commit: cccaf96 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55727 [ run ] completed with state SUCCESS. Commit: cccaf96
/LLM/main/L0_MergeRequest_PR pipeline #44629 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants